Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 7778017: Update references to the extension gallery. (Closed)

Created:
9 years, 3 months ago by kathyw
Modified:
9 years, 3 months ago
Reviewers:
Boris Smus
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org
Visibility:
Public.

Description

Update references to the extension gallery. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98889

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -61 lines) Patch
M chrome/common/extensions/docs/autoupdate.html View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/faq.html View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/common/extensions/docs/hosting.html View 1 chunk +2 lines, -9 lines 0 comments Download
M chrome/common/extensions/docs/manifest.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/npapi.html View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/packaging.html View 1 4 chunks +13 lines, -12 lines 1 comment Download
M chrome/common/extensions/docs/static/autoupdate.html View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/static/faq.html View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/common/extensions/docs/static/hosting.html View 1 chunk +2 lines, -9 lines 0 comments Download
M chrome/common/extensions/docs/static/manifest.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/static/npapi.html View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/common/extensions/docs/static/packaging.html View 1 4 chunks +13 lines, -12 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kathyw
9 years, 3 months ago (2011-08-30 20:27:14 UTC) #1
Boris Smus
LGTM with one nit. http://codereview.chromium.org/7778017/diff/2001/chrome/common/extensions/docs/packaging.html File chrome/common/extensions/docs/packaging.html (right): http://codereview.chromium.org/7778017/diff/2001/chrome/common/extensions/docs/packaging.html#newcode451 chrome/common/extensions/docs/packaging.html:451: specify the path to the ...
9 years, 3 months ago (2011-08-30 23:18:31 UTC) #2
kathyw
9 years, 3 months ago (2011-08-30 23:40:05 UTC) #3
http://codereview.chromium.org/7778017/diff/2001/chrome/common/extensions/doc...
> chrome/common/extensions/docs/packaging.html:451: specify the path to
> the extension's folder—for example,
> Deliberately removed spaces around the hyphen?
>
> http://codereview.chromium.org/7778017/

Yep, good catch. I've been removing spaces around em-dashes (to match
accepted style) as I edit files. I used to have the spaces because
some browsers wouldn't do line breaks on em-dashes (leading to
awkwardly short lines), but now most browsers to do the right thing.

-k-

Powered by Google App Engine
This is Rietveld 408576698