Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Unified Diff: content/browser/debugger/render_view_devtools_agent_host.h

Issue 7778010: DevTools: split DevToolsHandler into client and agent handlers (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Use private inheritance for observer interfaces Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/debugger/render_view_devtools_agent_host.h
diff --git a/content/browser/debugger/render_view_devtools_agent_host.h b/content/browser/debugger/render_view_devtools_agent_host.h
index 9950f2a0c8186b1b0c893bde2a090e1e616a0b6a..cd9fd956443a91034b992c7f6fd2ce5129affaa3 100644
--- a/content/browser/debugger/render_view_devtools_agent_host.h
+++ b/content/browser/debugger/render_view_devtools_agent_host.h
@@ -10,13 +10,12 @@
#include "base/basictypes.h"
#include "content/browser/debugger/devtools_agent_host.h"
-#include "content/common/notification_observer.h"
-#include "content/common/notification_registrar.h"
+#include "content/browser/renderer_host/render_view_host_observer.h"
class RenderViewHost;
class RenderViewDevToolsAgentHost : public DevToolsAgentHost,
- public NotificationObserver {
+ private RenderViewHostObserver {
public:
static DevToolsAgentHost* FindFor(RenderViewHost*);
@@ -29,13 +28,17 @@ class RenderViewDevToolsAgentHost : public DevToolsAgentHost,
virtual void NotifyClientClosing();
virtual int GetRenderProcessId();
- // Overridden from NotificationObserver:
- virtual void Observe(int type,
- const NotificationSource& source,
- const NotificationDetails& details);
+ // RenderViewHostObserver overrides.
+ virtual void RenderViewHostDestroyed() OVERRIDE;
+ virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
+
+ void OnForwardToClient(const IPC::Message& message);
+ void OnRuntimePropertyChanged(const std::string& name,
+ const std::string& value);
+ void OnClearBrowserCache();
+ void OnClearBrowserCookies();
RenderViewHost* render_view_host_;
- NotificationRegistrar registrar_;
typedef std::map<RenderViewHost*, RenderViewDevToolsAgentHost*> Instances;
static Instances instances_;
« no previous file with comments | « content/browser/debugger/devtools_manager_unittest.cc ('k') | content/browser/debugger/render_view_devtools_agent_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698