Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2162)

Issue 7778009: Adjust unit test to avoid flakyness when running with the ARM simulator. (Closed)

Created:
9 years, 3 months ago by fschneider
Modified:
9 years, 3 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Adjust unit test to avoid flakyness when running with the ARM simulator. In some cases the assert that the test function is not optimized fails because the function may be optimized already after the second invocation. (e.g. when running slow in debug mode) Committed: http://code.google.com/p/v8/source/detail?r=9034

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M test/mjsunit/assert-opt-and-deopt.js View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
fschneider
9 years, 3 months ago (2011-08-29 07:45:11 UTC) #1
Jakob Kummerow
9 years, 3 months ago (2011-08-29 07:48:29 UTC) #2
LGTM.

We've previously reduced this loop from 5 to 2 iterations due to flakiness, and
at first that seemed to be enough.
If the test is still flaky after this change, we should consider removing the
following assertOptCount(f, 0) and assertIsOptimized(f). In theory they're
correct, but flakiness sometimes defies theory...

Powered by Google App Engine
This is Rietveld 408576698