Truncate file name longer than MAX_PATH(260) on D2D

chrome/browser/ui/views/tab_contents/tab_contents_drag_win.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/tab_contents/tab_contents_drag_win.h"
 
 #include <windows.h>
 
 #include <string>
 
@@ skipping 209 matching lines @@
   // Enable asynchronous operation.
   ui::OSExchangeDataProviderWin::GetIAsyncOperation(*data)->SetAsyncMode(TRUE);
 }
 
 void TabContentsDragWin::PrepareDragForFileContents(
     const WebDropData& drop_data, ui::OSExchangeData* data) {
   // Images without ALT text will only have a file extension so we need to
   // synthesize one from the provided extension and URL.
   FilePath file_name(drop_data.file_description_filename);
   file_name = file_name.BaseName().RemoveExtension();
-  if (file_name.value().empty()) {
+
+  // If file_name contains percent-encoded characters, we want to decoded
+  // them to provide friendly file name for international users.
+  if (file_name.value().empty() ||
+      file_name.value().find('%') != std::string::npos) {

[sky, 2011/09/06 15:55:05]

If the file name contains a '%' and you enter this branch of the if statement
don't you throw away the file name altogether?

     // Retrieve the name from the URL.
     file_name = FilePath(
         net::GetSuggestedFilename(drop_data.url, "", "", "", "", string16()));
     if (file_name.value().size() + drop_data.file_extension.size() + 1 >
         MAX_PATH) {
       file_name = FilePath(file_name.value().substr(
           0, MAX_PATH - drop_data.file_extension.size() - 2));
     }
   }
   file_name = file_name.ReplaceExtension(drop_data.file_extension);
@@ skipping 116 matching lines @@
 
 void TabContentsDragWin::OnDataObjectDisposed() {
   DCHECK(drag_drop_thread_id_ == base::PlatformThread::CurrentId());
 
   // The drag-and-drop thread is only closed after OLE is done with
   // DataObjectImpl.
   BrowserThread::PostTask(
       BrowserThread::UI, FROM_HERE,
       NewRunnableMethod(this, &TabContentsDragWin::CloseThread));
 }