Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 7778008: Truncate file name longer than MAX_PATH(260) on D2D (Closed)

Created:
9 years, 3 months ago by yosin_UTC9
Modified:
9 years, 3 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

* Truncate file name longer than MAX_PATH(260). * Change for cpplint.py BUG=93601 TEST=Manual on Windows Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100373

Patch Set 1 #

Patch Set 2 : Decode Percent-Encoding in file name #

Total comments: 2

Patch Set 3 : Handle too long file extension #

Total comments: 8

Patch Set 4 : Take leading MAX_PATH-1 instead of considering file extension #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -15 lines) Patch
M ui/base/dragdrop/os_exchange_data_provider_win.cc View 1 2 3 4 chunks +16 lines, -15 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sky
http://codereview.chromium.org/7778008/diff/2001/chrome/browser/ui/views/tab_contents/tab_contents_drag_win.cc File chrome/browser/ui/views/tab_contents/tab_contents_drag_win.cc (right): http://codereview.chromium.org/7778008/diff/2001/chrome/browser/ui/views/tab_contents/tab_contents_drag_win.cc#newcode234 chrome/browser/ui/views/tab_contents/tab_contents_drag_win.cc:234: file_name.value().find('%') != std::string::npos) { If the file name contains ...
9 years, 3 months ago (2011-09-06 15:55:05 UTC) #1
yosin_UTC9
* Handle too long file extension * Move decoding URL encoded file name to another ...
9 years, 3 months ago (2011-09-08 11:19:20 UTC) #2
sky
http://codereview.chromium.org/7778008/diff/6001/ui/base/dragdrop/os_exchange_data_provider_win.cc File ui/base/dragdrop/os_exchange_data_provider_win.cc (right): http://codereview.chromium.org/7778008/diff/6001/ui/base/dragdrop/os_exchange_data_provider_win.cc#newcode409 ui/base/dragdrop/os_exchange_data_provider_win.cc:409: DCHECK_GT(c_data.Size(), static_cast<size_t>(0)); 0u http://codereview.chromium.org/7778008/diff/6001/ui/base/dragdrop/os_exchange_data_provider_win.cc#newcode895 ui/base/dragdrop/os_exchange_data_provider_win.cc:895: HANDLE hdata = GlobalAlloc(GMEM_MOVEABLE, ...
9 years, 3 months ago (2011-09-08 17:25:46 UTC) #3
yosin_UTC9
Hi Sky, Could you review again? I would like to keep this CR as small ...
9 years, 3 months ago (2011-09-09 04:25:41 UTC) #4
sky
LGTM
9 years, 3 months ago (2011-09-09 04:31:42 UTC) #5
commit-bot: I haz the power
9 years, 3 months ago (2011-09-09 08:57:27 UTC) #6
Change committed as 100373

Powered by Google App Engine
This is Rietveld 408576698