Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 7778004: Create libffmpeg.so in the component build. (Closed)

Created:
9 years, 3 months ago by darin (slow to review)
Modified:
9 years, 3 months ago
CC:
chromium-reviews, acolwell GONE FROM CHROMIUM
Visibility:
Public.

Description

Create libffmpeg.so in the component build. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98577

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M ffmpeg.gyp View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
darin (slow to review)
9 years, 3 months ago (2011-08-28 00:16:24 UTC) #1
Ami GONE FROM CHROMIUM
9 years, 3 months ago (2011-08-28 00:39:35 UTC) #2
Ami GONE FROM CHROMIUM
(sorry about previous empty email) LGTM modulo not really knowing what this stuff does. Hopefully ...
9 years, 3 months ago (2011-08-28 00:40:23 UTC) #3
darin (slow to review)
Thanks, but sadly there is no try bot coverage for this. The linux_shared bot does ...
9 years, 3 months ago (2011-08-28 04:07:35 UTC) #4
darin (slow to review)
Also, let me explain this change a bit further: I need to disable the visibility ...
9 years, 3 months ago (2011-08-28 04:09:05 UTC) #5
scherkus (not reviewing)
9 years, 3 months ago (2011-08-29 16:07:35 UTC) #6
On 2011/08/28 04:09:05, darin wrote:
> Also, let me explain this change a bit further:
> 
> I need to disable the visibility hidden compile time flag for this library so
> that all of the non-static symbols it defines get exported.  This avoids the
> need to tag each of the function declarations in the ffmpeg headers with a
> compiler attribute to declare default visibility.

post-commit LGTM!

Powered by Google App Engine
This is Rietveld 408576698