Issue 7778001: DevTools: introduce DevToolsAgentHost

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7778001: DevTools: introduce DevToolsAgentHost (Closed)

Created:
9 years, 3 months ago by yurys

Modified:
9 years, 3 months ago

Reviewers:
pfeldman

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

DevTools: introduce DevToolsAgentHost We need an abstract interface that would encapsulate communication with inspected instance's DevTools agent. It is going to have different implementations at least for render views and shared workers. This patch leaves all methods on the DevToolsManager that accept inspected RenderViewHost just for convenience. Eventually DevToolsManager should operate in terms of DevToolsAgentHost and DevToolsClientHost only. BUG=None TEST=DevTools tests TBR=pfeldman Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98598

Patch Set 1 #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+301 lines, -118 lines)			Patch
A	content/browser/debugger/devtools_agent_host.h	View	1 chunk	+44 lines, -0 lines	0 comments	Download
A	content/browser/debugger/devtools_agent_host.cc	View	1 chunk	+18 lines, -0 lines	0 comments	Download
M	content/browser/debugger/devtools_manager.h	View	6 chunks	+24 lines, -23 lines	0 comments	Download
M	content/browser/debugger/devtools_manager.cc	View	10 chunks	+107 lines, -95 lines	0 comments	Download
A	content/browser/debugger/render_view_devtools_agent_host.h	View	1 chunk	+46 lines, -0 lines	0 comments	Download
A	content/browser/debugger/render_view_devtools_agent_host.cc	View	1 chunk	+58 lines, -0 lines	0 comments	Download
M	content/content_browser.gypi	View	2 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

yurys

9 years, 3 months ago (2011-08-27 06:39:59 UTC) #1

This is an improved version of
http://src.chromium.org/viewvc/chrome?view=rev&revision=98552 which was reverted
due to devtools manager unit tests failures. It is fixed now by reseting close
listener on the devtools agent when it is unbound.

Expand Messages | Collapse Messages