Issue 7777005: MIPS: Fixed a bug in a special case of MacroAssembler::Ext.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7777005: MIPS: Fixed a bug in a special case of MacroAssembler::Ext. (Closed)

Created:
9 years, 3 months ago by Paul Lind

Modified:
9 years, 3 months ago

Reviewers:
fschneider

CC:
v8-dev

Visibility:
Public.

Description

MIPS: Fixed a bug in a special case of MacroAssembler::Ext. In mips32r1 mode the target register was not be properly set up when shift_left == 0. BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=9032

Patch Set 1 #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -3 lines)			Patch
	M	src/mips/macro-assembler-mips.cc	View		1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Paul Lind

this fixes a bug in Issue 7744014 (http://codereview.chromium.org/7744014/) which you landed for me last week ...

9 years, 3 months ago (2011-08-29 06:09:27 UTC) #1

LGTM.

Will land it.

Expand Messages | Collapse Messages