Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(909)

Issue 7777002: Add a --unmanaged flag to gclient config to allow the main solution to be unmanaged by the scm. (Closed)

Created:
9 years, 3 months ago by Nicolas Sylvain
Modified:
9 years, 3 months ago
CC:
chromium-reviews, M-A Ruel
Visibility:
Public.

Description

Add a --unmanaged flag to gclient config to allow the main solution to be unmanaged by the scm. The dependencies will continue to be managed. A new flag is present in the .gclient file to control this behavior.

Patch Set 1 #

Total comments: 7
Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -17 lines) Patch
M gclient.py View 12 chunks +26 lines, -13 lines 7 comments Download
M gclient_scm.py View 4 chunks +21 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Nicolas Sylvain
9 years, 3 months ago (2011-08-27 23:57:57 UTC) #1
nsylvain
Adding dpranke and fischman in CC. They can tell if this will be useful to ...
9 years, 3 months ago (2011-08-27 23:59:17 UTC) #2
Ami GONE FROM CHROMIUM
On 2011/08/27 23:59:17, nsylvain wrote: > Adding dpranke and fischman in CC. They can tell ...
9 years, 3 months ago (2011-08-28 00:06:48 UTC) #3
nsylvain
this is indeed my attempt at that. With this you'll have to manage updating src/ ...
9 years, 3 months ago (2011-08-28 00:59:51 UTC) #4
Ami GONE FROM CHROMIUM
SGTM
9 years, 3 months ago (2011-08-28 01:44:09 UTC) #5
M-A Ruel
http://codereview.chromium.org/7777002/diff/1/gclient.py File gclient.py (right): http://codereview.chromium.org/7777002/diff/1/gclient.py#newcode335 gclient.py:335: None, self.deps_file, should_process)) So it's not inheritable? http://codereview.chromium.org/7777002/diff/1/gclient.py#newcode401 gclient.py:401: ...
9 years, 3 months ago (2011-08-28 13:03:31 UTC) #6
nsylvain
http://codereview.chromium.org/7777002/diff/1/gclient.py File gclient.py (right): http://codereview.chromium.org/7777002/diff/1/gclient.py#newcode335 gclient.py:335: None, self.deps_file, should_process)) On 2011/08/28 13:03:31, Marc-Antoine Ruel wrote: ...
9 years, 3 months ago (2011-08-29 18:03:58 UTC) #7
cmp
lgtm
9 years, 3 months ago (2011-08-29 19:01:59 UTC) #8
Dirk Pranke
http://codereview.chromium.org/7777002/diff/1/gclient.py File gclient.py (right): http://codereview.chromium.org/7777002/diff/1/gclient.py#newcode984 gclient.py:984: parser.add_option('--unmanaged', action='store_true', On 2011/08/29 18:03:58, nsylvain wrote: > because ...
9 years, 3 months ago (2011-08-29 20:56:13 UTC) #9
cmp
9 years, 3 months ago (2011-09-16 18:47:28 UTC) #10

Powered by Google App Engine
This is Rietveld 408576698