Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 7776034: Use chain-loading for Linux nacl_helper (Closed)

Created:
9 years, 3 months ago by Roland McGrath
Modified:
9 years, 3 months ago
CC:
chromium-reviews, native-client-reviews_googlegroups.com, pam+watch_chromium.org
Visibility:
Public.

Description

Use chain-loading for Linux nacl_helper This replaces the nacl_helper_bootstrap program, dynamically-linked against nacl_helper.so, with a standalone, statically-linked nacl_helper_bootstrap program that loads the dynamic linker, instructing it in turn to load the nacl_helper program (now a PIE rather than a DSO). This avoids two problems with the old scheme: 1. The nacl_helper_bootstrap program remained in the dynamic linker's list of loaded objects, as the main executable, even though the memory where its .dynamic section had been was overwritten with the NaCl untrusted address space. Code that traverses the list of all loaded objects could thus attempt to look at pointers into this part of memory, and be led astray. 2. nacl_helper_bootstrap's large (~1G) bss segment could cause the kernel to refuse to load the program because it didn't think there was enough free memory in the system for so large an allocation of anonymous memory. The bootstrap program is kept very small by avoiding all use of libc (except for memset and integer division routines needed on ARM). It has its own custom start-up code hand-written in assembly and its own custom system call stubs done with hand-written GCC inline asm statements. To avoid the second problem, the bootstrap program no longer has a large bss. Instead, it has a special ELF segment (i.e. PT_LOAD header) that specifies no memory access, and a large (~1G) mapping size from the file. This mapping is way off the end of the file, but the kernel doesn't mind that, and since it's all a file mapping, the kernel does not do its normal memory accounting for consuming a large amount of anonymous memory. Unfortunately, it's impossible to get the linker to produce exactly the right PT_LOAD header by itself. Using a custom linker script, we get the layout exactly how we want it and a PT_LOAD header that is almost right. We then use a build-time helper program to munge one field of the PT_LOAD to make it exactly what we need. BUG= http://code.google.com/p/chromium/issues/detail?id=94147 TEST= hand-tested chromium build R=bradchen@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99089

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : rebased #

Patch Set 4 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+739 lines, -81 lines) Patch
M build/install-build-deps.sh View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_installer.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/chrome_paths.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_paths.cc View 2 chunks +8 lines, -1 line 0 comments Download
M chrome/nacl.gypi View 3 chunks +93 lines, -23 lines 0 comments Download
M chrome/nacl/nacl_fork_delegate_linux.cc View 2 chunks +10 lines, -8 lines 0 comments Download
M chrome/nacl/nacl_helper_bootstrap_linux.c View 1 chunk +419 lines, -14 lines 0 comments Download
A chrome/nacl/nacl_helper_bootstrap_linux.x View 1 chunk +93 lines, -0 lines 0 comments Download
A chrome/nacl/nacl_helper_bootstrap_munge_phdr.c View 1 chunk +66 lines, -0 lines 0 comments Download
A chrome/nacl/nacl_helper_bootstrap_munge_phdr.py View 1 chunk +36 lines, -0 lines 0 comments Download
D chrome/nacl/nacl_helper_exports.txt View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/nacl/nacl_helper_linux.cc View 2 chunks +7 lines, -19 lines 0 comments Download
M chrome/tools/build/chromeos/FILES.cfg View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/tools/build/linux/FILES View 1 chunk +1 line, -1 line 0 comments Download
M chrome/tools/build/linux/FILES.cfg View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Roland McGrath
This was previously reviewed at http://codereview.chromium.org/7795010/ and committed. It then had to be reverted due ...
9 years, 3 months ago (2011-08-31 16:43:11 UTC) #1
Brad Chen
LGTM
9 years, 3 months ago (2011-08-31 17:04:01 UTC) #2
commit-bot: I haz the power
No LGTM from valid reviewers yet.
9 years, 3 months ago (2011-08-31 22:01:41 UTC) #3
Mark Seaborn
Rubber-stamp LGTM to make the commit bot happy.
9 years, 3 months ago (2011-08-31 22:15:51 UTC) #4
Brad Chen
LGTM
9 years, 3 months ago (2011-08-31 22:25:21 UTC) #5
commit-bot: I haz the power
9 years, 3 months ago (2011-09-01 00:55:13 UTC) #6
Change committed as 99089

Powered by Google App Engine
This is Rietveld 408576698