Handling file actions in only one instance of file manager.

Handling file actions in only one instance of file manager.

BUG=chromium-os:18604
TEST=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99772

[SeRya, 2011-08-31 14:32:21]

Please, review.

I used a trick similar to one used by slideshow.html to receive arguments so to
should work fine.

[rginda, 2011-08-31 18:10:03]

I don't think this is going to be enough.  If a user starts a task in anything
but the first file manager tab, its results will show in a different tab.

For example, start to format a device in the second file manager tab, and the
"Format complete" message will appear in the first.

http://codereview.chromium.org/7776031/diff/1/chrome/browser/resources/file_m...
File chrome/browser/resources/file_manager/js/file_manager.js (right):

http://codereview.chromium.org/7776031/diff/1/chrome/browser/resources/file_m...
chrome/browser/resources/file_manager/js/file_manager.js:1850: // handled once.
Let's it be the first instance in the list returned by
s/Let's/Let/

http://codereview.chromium.org/7776031/diff/1/chrome/browser/resources/file_m...
chrome/browser/resources/file_manager/js/file_manager.js:1854: if ('fileManager'
in windows[i]) {
This seems hokey.  Any window with a variable called fileManager will trigger
this.  Comparing URLs seems more robust.

http://codereview.chromium.org/7776031/diff/1/chrome/browser/resources/file_m...
chrome/browser/resources/file_manager/js/file_manager.js:1855: if
(windows[i]['fileManager'] == this) break;
Newline and indent before break and return, please.

[SeRya, 2011-09-01 18:13:49]

You are right, showing confirmation box for the 'format-device' task makes this
approach inapplicable. I'm suggesting to not use regular task delivery mechanism
for internal tasks.

[zel, 2011-09-06 16:39:30]

LGTM

[rginda, 2011-09-06 18:21:45]

On 2011/09/06 16:39:30, zel wrote:
> LGTM

LGTM too

[commit-bot: I haz the power, 2011-09-06 18:36:10]

Change committed as 99772