Implement reverse mangling of svn properties.

Implement reverse mangling of svn properties.

That means some properties will being to be applied.

R=dpranke@chromium.org
BUG=
TEST=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99182

[Dirk Pranke, 2011-08-30 20:44:57]

http://codereview.chromium.org/7776015/diff/1/rietveld.py
File rietveld.py (right):

http://codereview.chromium.org/7776015/diff/1/rietveld.py#newcode175
rietveld.py:175: if rietveld_svn_props.pop(0) or not rietveld_svn_props:
What is the format of the the rietveld_svn_props list? is the first line
guaranteed to be empty?

Also, I find the use of pop() inside method calls and if branches to be a bit
confusing; perhaps it would be clearer if you pulled the popped values into
local variables?

[M-A Ruel, 2011-08-30 21:01:33]

http://codereview.chromium.org/7776015/diff/1/rietveld.py
File rietveld.py (right):

http://codereview.chromium.org/7776015/diff/1/rietveld.py#newcode175
rietveld.py:175: if rietveld_svn_props.pop(0) or not rietveld_svn_props:
On 2011/08/30 20:44:58, Dirk Pranke wrote:
> What is the format of the the rietveld_svn_props list? is the first line
> guaranteed to be empty?

It's the exact format of a svn diff.

> Also, I find the use of pop() inside method calls and if branches to be a bit
> confusing; perhaps it would be clearer if you pulled the popped values into
> local variables?

Done.

[Dirk Pranke, 2011-08-30 21:11:04]

LGTM. Much clearer, thank you!