Introduce local function declarations in Crankshaft and fix issue 1647.

Introduce local function declarations in Crankshaft and fix issue 1647.

We have to emit code for declarations later into the body block
(and not into the start block) so that the environment contains
the correct values.

In order to capture the environment effect of the declarations
that generate code (function declarations) I inserted a separate
AST id and a HSimulate after the declarations are visited.

Also fixes handling deopt in named function expressions:
BUG=v8:1647
TEST=test/mjsunit/regress/regress-fundecl.js, test/mjsunit/regress/regress-1647.js
Committed: http://code.google.com/p/v8/source/detail?r=9083

[fschneider, 2011-08-30 07:56:19]

New attempt. Added a separate ast id for declarations and emit code for
declarations after the start block.

[Kevin Millikin (Chromium), 2011-08-31 11:44:27]

It needs the change we discussed (below).  After that, LGTM.

http://codereview.chromium.org/7776009/diff/10001/src/hydrogen.cc
File src/hydrogen.cc (right):

http://codereview.chromium.org/7776009/diff/10001/src/hydrogen.cc#newcode2298
src/hydrogen.cc:2298: VisitDeclarations(scope->declarations());
There's an implicit declaration of the function name as a const, so you need
something like:

if (scope()->is_function_scope() && scope()->function() != NULL) {
  environmnent()->Bind(scope()->function(), <the hole value>);
}

before VisitDeclarations.

[fschneider, 2011-08-31 12:09:40]

http://codereview.chromium.org/7776009/diff/10001/src/hydrogen.cc
File src/hydrogen.cc (right):

http://codereview.chromium.org/7776009/diff/10001/src/hydrogen.cc#newcode2298
src/hydrogen.cc:2298: VisitDeclarations(scope->declarations());
On 2011/08/31 11:44:27, Kevin Millikin wrote:
> There's an implicit declaration of the function name as a const, so you need
> something like:
> 
> if (scope()->is_function_scope() && scope()->function() != NULL) {
>   environmnent()->Bind(scope()->function(), <the hole value>);
> }
> 
> before VisitDeclarations.

Done.