Issue 7776008: Make built-in functions not rely on callback functions .call method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7776008: Make built-in functions not rely on callback functions .call method. (Closed)

Created:
9 years, 3 months ago by Lasse Reichstein

Modified:
9 years, 3 months ago

Reviewers:
Erik Corry, William Hesse

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Make built-in functions not rely on callback functions .call method. In builtin code, we can't rely on Function.prototype.call being unmolested. Committed: http://code.google.com/p/v8/source/detail?r=9053

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix bugs in last two functions changed. #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -7 lines)			Patch
	M	src/array.js	View	1	10 chunks	+25 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

William Hesse

LGTM, after error is fixed. http://codereview.chromium.org/7776008/diff/1/src/array.js File src/array.js (right): http://codereview.chromium.org/7776008/diff/1/src/array.js#newcode1268 src/array.js:1268: var receiver = %GetDefaultReceiver(f); ...

9 years, 3 months ago (2011-08-29 10:50:37 UTC) #2

Is there a regression test for this?

Expand Messages | Collapse Messages