Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1104)

Unified Diff: chrome/browser/extensions/extension_install_ui.cc

Issue 7776001: ntp4: improved app install, try 2 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove #app-id altogether Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_install_ui.cc
diff --git a/chrome/browser/extensions/extension_install_ui.cc b/chrome/browser/extensions/extension_install_ui.cc
index 0717acd7bedda56e47625d2acced774b713bce99..d0b240d69ca7c932e24a64699f25e887ecb73ade 100644
--- a/chrome/browser/extensions/extension_install_ui.cc
+++ b/chrome/browser/extensions/extension_install_ui.cc
@@ -231,12 +231,14 @@ void ExtensionInstallUI::OnImageLoaded(
// static
void ExtensionInstallUI::OpenAppInstalledNTP(Browser* browser,
const std::string& app_id) {
- std::string url = base::StringPrintf(
- "%s#app-id=%s", chrome::kChromeUINewTabURL, app_id.c_str());
browser::NavigateParams params =
- browser->GetSingletonTabNavigateParams(GURL(url));
- params.path_behavior = browser::NavigateParams::IGNORE_AND_NAVIGATE;
+ browser->GetSingletonTabNavigateParams(GURL(chrome::kChromeUINewTabURL));
browser::Navigate(&params);
+
+ NotificationService::current()->Notify(
+ chrome::NOTIFICATION_APP_INSTALLED_TO_NTP,
+ Source<TabContents>(params.target_contents->tab_contents()),
+ Details<const std::string>(&app_id));
}
// static

Powered by Google App Engine
This is Rietveld 408576698