ntp4: improved app install, try 2

chrome/browser/resources/ntp4/apps_page.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('ntp4', function() {
   'use strict';
 
   var localStrings = new LocalStrings;
 
   var APP_LAUNCH = {
@@ skipping 394 matching lines @@
       this.classList.add('apps-page');
     },
 
     /**
      * Creates an app DOM element and places it at the last position on the
      * page.
      * @param {Object} appData The data object that describes the app.
      * @param {?boolean} animate If true, the app tile plays an animation.
      */
     appendApp: function(appData, animate) {
+      if (animate) {
+        // Select the page and scroll all the way down so the animation is
+        // visible.
+        ntp4.getCardSlider().selectCardByValue(this);
+        console.log('selecting card');

[Rick Byers, 2011/08/29 16:01:00]

We don't generally want to leave diagnostic logging in the code, right?

[Evan Stade, 2011/08/29 18:15:16]

correct, left here by mistake

+        this.content_.scrollTop = this.content_.scrollHeight;
+      }
       this.appendTile(new App(appData), animate);
     },
 
     /** @inheritdoc */
     doDragOver: function(e) {
       var tile = ntp4.getCurrentlyDraggingTile();
       if (!tile.querySelector('.app')) {
         e.preventDefault();
         this.setDropEffect(e.dataTransfer);
       } else {
@@ skipping 107 matching lines @@
     var store = document.querySelector('.webstore');
     if (store)
       store.setAppsPromoData(data);
   };
 
   return {
     APP_LAUNCH: APP_LAUNCH,
     AppsPage: AppsPage,
   };
 });