Enable sync for the settings from the Extension Settings API.

chrome/browser/sync/glue/extension_setting_data_type_controller.cc

Index: chrome/browser/sync/glue/extension_setting_data_type_controller.cc
diff --git a/chrome/browser/sync/glue/extension_setting_data_type_controller.cc b/chrome/browser/sync/glue/extension_setting_data_type_controller.cc
new file mode 100644
index 0000000000000000000000000000000000000000..b8cc9c39bc4b6ced45a464acaf9a4b6684cea2a0
--- /dev/null
+++ b/chrome/browser/sync/glue/extension_setting_data_type_controller.cc
@@ -0,0 +1,91 @@
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/sync/glue/extension_setting_data_type_controller.h"
+
+#include "base/metrics/histogram.h"
+#include "chrome/browser/sync/api/syncable_service.h"
+#include "chrome/browser/sync/glue/generic_change_processor.h"
+#include "content/browser/browser_thread.h"
+
+namespace browser_sync {
+
+ExtensionSettingDataTypeController::ExtensionSettingDataTypeController(
+    ProfileSyncFactory* profile_sync_factory,
+    Profile* profile,
+    ProfileSyncService* profile_sync_service)
+    : NonFrontendDataTypeController(profile_sync_factory, profile),
+      profile_sync_service_(profile_sync_service) {}

[akalin, 2011/09/21 01:58:41]

stash a pointer to ExtensionSettingsUIWrapper:

extension_settings_ui_wrapper_(profile->GetExtensionService()->GetExtensionSettingsUIWrapper())

also DCHECK on UI thread

[not at google - send to devlin, 2011/09/21 03:55:18]

Done.

+
+ExtensionSettingDataTypeController::~ExtensionSettingDataTypeController() {}
+
+syncable::ModelType ExtensionSettingDataTypeController::type() const {
+  return syncable::EXTENSION_SETTINGS;
+}
+
+browser_sync::ModelSafeGroup
+ExtensionSettingDataTypeController::model_safe_group() const {
+  return browser_sync::GROUP_FILE;
+}
+
+bool ExtensionSettingDataTypeController::StartModels() {
+  return true;
+}
+
+bool ExtensionSettingDataTypeController::StartAssociationAsync() {
+  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+  DCHECK_EQ(state(), ASSOCIATING);
+  if (!BrowserThread::PostTask(

[akalin, 2011/09/21 01:58:41]

instead of this, do:

extension_settings_ui_wrapper_->RunWithExtensionSettings(base::Bind(&StartAssociationWithExtensionSettings,
this));

[not at google - send to devlin, 2011/09/21 03:55:18]

Done.

+        BrowserThread::FILE,
+        FROM_HERE,
+        base::Bind(
+            &ExtensionSettingDataTypeController::StartAssociation,
+            this))) {
+    NOTREACHED();
+  }
+  return true;
+}

[akalin, 2011/09/21 01:58:41]

have:

void StartAssociationWithExtensionSettings(ExtensionSettings*
extension_settings) {
  DCHECK(on file thread);
  extension_settings_ = extension_settings;
  // calls CreateSyncComponents.
  StartAssociation();
}

[not at google - send to devlin, 2011/09/21 03:55:18]

Done.

+
+void ExtensionSettingDataTypeController::CreateSyncComponents() {
+  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
+  DCHECK_EQ(state(), ASSOCIATING);
+  ProfileSyncFactory::SyncComponents sync_components =
+      profile_sync_factory()->CreateExtensionSettingSyncComponents(

[akalin, 2011/09/21 01:58:41]

pass in extension_settings_ (DCHECK it's non-NULL) here

[not at google - send to devlin, 2011/09/21 03:55:18]

Done.

+          profile_sync_service_, this);
+  set_model_associator(sync_components.model_associator);
+  set_change_processor(sync_components.change_processor);
+}
+
+bool ExtensionSettingDataTypeController::StopAssociationAsync() {
+  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+  DCHECK_EQ(state(), STOPPING);
+  if (!BrowserThread::PostTask(
+          BrowserThread::FILE,
+          FROM_HERE,
+          base::Bind(
+              &ExtensionSettingDataTypeController::StopAssociation,
+              this))) {
+    NOTREACHED();
+  }
+  return true;
+}
+
+void ExtensionSettingDataTypeController::RecordUnrecoverableError(
+    const tracked_objects::Location& from_here,
+    const std::string& message) {
+  UMA_HISTOGRAM_COUNTS("Sync.ExtensionSettingRunFailures", 1);
+}
+
+void ExtensionSettingDataTypeController::RecordAssociationTime(
+    base::TimeDelta time) {
+  UMA_HISTOGRAM_TIMES("Sync.ExtensionSettingAssociationTime", time);
+}
+
+void ExtensionSettingDataTypeController::RecordStartFailure(
+    StartResult result) {
+  UMA_HISTOGRAM_ENUMERATION(
+      "Sync.ExtensionSettingStartFailures", result, MAX_START_RESULT);
+}
+
+}  // namespace browser_sync