chrome/browser/extensions/extension_settings_api.h - Issue 7775008: Enable sync for the settings from the Extension Settings API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_settings_api.h

Issue 7775008: Enable sync for the settings from the Extension Settings API. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Review #5 Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_settings_api.h

diff --git a/chrome/browser/extensions/extension_settings_api.h b/chrome/browser/extensions/extension_settings_api.h

index 1ca2180b41d90683b73ea47ba2861963d7af736a..15c39e976539be936d4cd8a6c9efc2abfb1f7123 100644

--- a/chrome/browser/extensions/extension_settings_api.h

+++ b/chrome/browser/extensions/extension_settings_api.h

@@ -28,8 +28,9 @@ class SettingsFunction : public AsyncExtensionFunction {

bool UseResult(const ExtensionSettingsStorage::Result& storage_result);

private:

- // Component of RunImpl which runs on the FILE thread.

- void RunOnFileThread();

+ // Called via PostTask from RunImpl. Runs RunWithStorage and runs

+ // SendReponse with its success value.

+ void RunWithStorageOnFileThread(ExtensionSettingsStorage* storage);

};

class GetSettingsFunction : public SettingsFunction {