Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1590)

Unified Diff: chrome/browser/extensions/extension_setting_sync_data.h

Issue 7775008: Enable sync for the settings from the Extension Settings API. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Review #2 against correct branch Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_setting_sync_data.h
diff --git a/chrome/browser/extensions/extension_setting_sync_data.h b/chrome/browser/extensions/extension_setting_sync_data.h
new file mode 100644
index 0000000000000000000000000000000000000000..37a7aba06b511b3cdac288e6f92a838ec1f550c7
--- /dev/null
+++ b/chrome/browser/extensions/extension_setting_sync_data.h
@@ -0,0 +1,76 @@
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_SETTING_SYNC_DATA_H_
+#define CHROME_BROWSER_EXTENSIONS_EXTENSION_SETTING_SYNC_DATA_H_
+#pragma once
+
+#include "base/memory/ref_counted.h"
+#include "base/memory/scoped_ptr.h"
+#include "base/values.h"
+#include "chrome/browser/sync/api/sync_data.h"
+#include "chrome/browser/sync/api/sync_change.h"
+
+// Container for data interpreted from sync data/changes. Safe and efficient
+// to copy.
+class ExtensionSettingSyncData {
+ public:
+ // Creates from a sync change.
+ explicit ExtensionSettingSyncData(const SyncChange& sync_change);
+
+ // Creates from sync data. change_type will be ACTION_INVALID.
+ explicit ExtensionSettingSyncData(const SyncData& sync_data);
+
+ ExtensionSettingSyncData(
+ SyncChange::SyncChangeType change_type,
+ const std::string& extension_id,
+ const std::string& key,
+ // May be NULL. Ownership taken if not.
+ Value* value);
+
+ ~ExtensionSettingSyncData();
+
+ // Returns the type of the sync change; may be ACTION_INVALID.
+ SyncChange::SyncChangeType change_type() const;
+
+ // Returns the extension id the setting is for.
+ const std::string& extension_id() const;
+
+ // Returns the settings key.
+ const std::string& key() const;
+
+ // Returns the value of the setting, possibly NULL.
akalin 2011/09/17 08:44:47 fix comment
not at google - send to devlin 2011/09/19 07:10:47 Done.
+ // Ownership NOT given up.
+ const Value& value() const;
+
+ private:
+ // Ref-counted container for the data.
+ // TODO(kalman): Use browser_sync::Immutable<Internal>.
+ class Internal : public base::RefCountedThreadSafe<Internal> {
+ public:
+ explicit Internal(
+ SyncChange::SyncChangeType change_type,
+ const std::string& extension_id,
+ const std::string& key,
+ Value* value);
+
+ SyncChange::SyncChangeType change_type_;
+ std::string extension_id_;
+ std::string key_;
+ scoped_ptr<Value> value_;
+
+ private:
+ friend class base::RefCountedThreadSafe<Internal>;
+ ~Internal();
+ };
+
+ // Initializes internal_ from sync data.
+ void Init(SyncChange::SyncChangeType change_type, const SyncData& sync_data);
+
+ scoped_refptr<Internal> internal_;
+};
+
+typedef std::vector<ExtensionSettingSyncData> ExtensionSettingSyncDataList;
+
+#endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_SETTING_SYNC_DATA_H_

Powered by Google App Engine
This is Rietveld 408576698