Enable sync for the settings from the Extension Settings API.

chrome/browser/extensions/extension_service.h

Index: chrome/browser/extensions/extension_service.h
diff --git a/chrome/browser/extensions/extension_service.h b/chrome/browser/extensions/extension_service.h
index 276406cd500848793bfe8191d068724cb129ee31..f4eeb0b65dac513db321319b633c977210fbba55 100644
--- a/chrome/browser/extensions/extension_service.h
+++ b/chrome/browser/extensions/extension_service.h
@@ -76,6 +76,11 @@ class ExtensionServiceInterface : public SyncableService {
   typedef bool (*ExtensionFilter)(const Extension&);
 
   virtual ~ExtensionServiceInterface() {}
+
+  // Gets the list of all installed extension IDs, including disabled and
+  // terminated extensions.
+  virtual const std::vector<std::string> GetAllExtensionIds() const = 0;

[Ben Olmstead, 2011/09/16 18:21:43]

I'm entirely in favor of adding this method.

[akalin, 2011/09/17 08:44:47]

const doesn't make sense in a return value

[akalin, 2011/09/17 08:44:47]

May want to decomp this change out and check that in separately, esp. given my
comment in the .cc file to make GetAllSyncData use this fn.

[not at google - send to devlin, 2011/09/19 07:10:47]

No longer needed.

+
   virtual const ExtensionList* extensions() const = 0;
   virtual PendingExtensionManager* pending_extension_manager() = 0;
 
@@ -184,6 +189,10 @@ class ExtensionService
 
   virtual ~ExtensionService();
 
+  // Gets the list of all installed extension IDs, including disabled and
+  // terminated extensions.
+  virtual const std::vector<std::string> GetAllExtensionIds() const;
+
   // Gets the list of currently installed extensions.

[Ben Olmstead, 2011/09/16 18:21:43]

While you're in here, could you change this comment to something like "Gets the
list of currently running extensions."?

[not at google - send to devlin, 2011/09/19 07:10:47]

Maybe the GetAllExtensionIDs and/or the comment update should happen in an
entirely unrelated patch, but it's not needed for the sync stuff anymore.

   virtual const ExtensionList* extensions() const OVERRIDE;
   const ExtensionList* disabled_extensions() const;