Enable sync for the settings from the Extension Settings API.

chrome/browser/extensions/extension_setting_sync_data.h

Index: chrome/browser/extensions/extension_setting_sync_data.h
diff --git a/chrome/browser/extensions/extension_setting_sync_data.h b/chrome/browser/extensions/extension_setting_sync_data.h
new file mode 100644
index 0000000000000000000000000000000000000000..202cf1605a35a7434a9ef597c19d01589fb41e5a
--- /dev/null
+++ b/chrome/browser/extensions/extension_setting_sync_data.h
@@ -0,0 +1,72 @@
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_SETTING_SYNC_DATA_H_
+#define CHROME_BROWSER_EXTENSIONS_EXTENSION_SETTING_SYNC_DATA_H_
+#pragma once
+
+#include "base/memory/ref_counted.h"
+#include "base/memory/scoped_ptr.h"
+#include "base/values.h"
+#include "chrome/browser/sync/api/sync_data.h"
+#include "chrome/browser/sync/api/sync_change.h"
+
+// Container for data interpreted from sync data/changes.  Safe and efficient
+// to copy.
+class ExtensionSettingSyncData {
+ public:
+  // Creates from a sync change.
+  explicit ExtensionSettingSyncData(const SyncChange& sync_change);
+
+  // Creates from sync data.  change_type will be ACTION_INVALID.
+  explicit ExtensionSettingSyncData(const SyncData& sync_data);
+
+  ExtensionSettingSyncData(
+      SyncChange::SyncChangeType change_type,
+      const std::string& extension_id,
+      const std::string& key,
+      // May be NULL.  Ownership taken if not.
+      Value* value);
+
+  ~ExtensionSettingSyncData();
+
+  // Returns the type of the sync change; may be ACTION_INVALID.
+  SyncChange::SyncChangeType change_type() const;
+
+  // Returns the extension id the setting is for.
+  const std::string& extension_id() const;
+
+  // Returns the settings key.
+  const std::string& key() const;
+
+  // Returns the value of the setting, possibly NULL.
+  // Ownership NOT given up.
+  const Value* value() const;

[akalin, 2011/09/15 19:56:44]

should return const Value&

[not at google - send to devlin, 2011/09/16 05:18:59]

Done.

+
+ private:
+  // Ref-counted container for the data.

[akalin, 2011/09/15 19:56:44]

Add TODO to use Immutable<T> (see http://codereview.chromium.org/7904021/ )

[not at google - send to devlin, 2011/09/16 05:18:59]

Done.

+  class Internal : public base::RefCountedThreadSafe<Internal> {
+   public:
+    explicit Internal(
+      SyncChange::SyncChangeType change_type,
+      const std::string& extension_id,
+      const std::string& key,
+      Value* value);
+
+    SyncChange::SyncChangeType change_type_;
+    std::string extension_id_;
+    std::string key_;
+    scoped_ptr<Value> value_;
+
+   private:
+    friend class base::RefCountedThreadSafe<Internal>;
+    virtual ~Internal();

[akalin, 2011/09/15 19:56:44]

no need for virtual

[not at google - send to devlin, 2011/09/16 05:18:59]

IIRC clang complains if a destructor isn't virtual and it's inherited.

Or maybe it only complains if there are actually virtual methods defined on the
class.  Hmm.  I'll try removing virtual and hope for the best.

+  };
+
+  scoped_refptr<Internal> internal_;
+};
+
+typedef std::vector<ExtensionSettingSyncData> ExtensionSettingSyncDataList;
+
+#endif  // CHROME_BROWSER_EXTENSIONS_EXTENSION_SETTING_SYNC_DATA_H_