Enable sync for the settings from the Extension Settings API.

chrome/browser/extensions/extension_service.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_
 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_
 #pragma once
 
 #include <map>
 #include <set>
@@ skipping 58 matching lines @@
 // This is an interface class to encapsulate the dependencies that
 // various classes have on ExtensionService. This allows easy mocking.
 class ExtensionServiceInterface : public SyncableService {
  public:
   // A function that returns true if the given extension should be
   // included and false if it should be filtered out.  Identical to
   // PendingExtensionInfo::ShouldAllowInstallPredicate.
   typedef bool (*ExtensionFilter)(const Extension&);
 
   virtual ~ExtensionServiceInterface() {}
+
+  // Gets the list of all installed extension IDs, including disabled and
+  // terminated extensions.
+  virtual const std::vector<std::string> GetAllExtensionIds() const = 0;

[Ben Olmstead, 2011/09/16 18:21:43]

I'm entirely in favor of adding this method.

[akalin, 2011/09/17 08:44:47]

const doesn't make sense in a return value

[akalin, 2011/09/17 08:44:47]

May want to decomp this change out and check that in separately, esp. given my
comment in the .cc file to make GetAllSyncData use this fn.

[not at google - send to devlin, 2011/09/19 07:10:47]

No longer needed.

+
   virtual const ExtensionList* extensions() const = 0;
   virtual PendingExtensionManager* pending_extension_manager() = 0;
 
   // Install an update.  Return true if the install can be started.
   // Set out_crx_installer to the installer if one was started.
   virtual bool UpdateExtension(
       const std::string& id,
       const FilePath& path,
       const GURL& download_url,
       CrxInstaller** out_crx_installer) = 0;
@@ skipping 88 matching lines @@
   ExtensionService(Profile* profile,
                    const CommandLine* command_line,
                    const FilePath& install_directory,
                    ExtensionPrefs* extension_prefs,
                    ExtensionSettings* extension_settings,
                    bool autoupdate_enabled,
                    bool extensions_enabled);
 
   virtual ~ExtensionService();
 
+  // Gets the list of all installed extension IDs, including disabled and
+  // terminated extensions.
+  virtual const std::vector<std::string> GetAllExtensionIds() const;
+
   // Gets the list of currently installed extensions.

[Ben Olmstead, 2011/09/16 18:21:43]

While you're in here, could you change this comment to something like "Gets the
list of currently running extensions."?

[not at google - send to devlin, 2011/09/19 07:10:47]

Maybe the GetAllExtensionIDs and/or the comment update should happen in an
entirely unrelated patch, but it's not needed for the sync stuff anymore.

   virtual const ExtensionList* extensions() const OVERRIDE;
   const ExtensionList* disabled_extensions() const;
   const ExtensionList* terminated_extensions() const;
 
   // Gets the object managing the set of pending extensions.
   virtual PendingExtensionManager* pending_extension_manager() OVERRIDE;
 
   // Registers an extension to be loaded as a component extension.
   void register_component_extension(const ComponentExtensionInfo& info) {
     component_extension_manifests_.push_back(info);
@@ skipping 597 matching lines @@
   SyncBundle extension_sync_bundle_;
 
   FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest,
                            InstallAppsWithUnlimtedStorage);
   FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest,
                            InstallAppsAndCheckStorageProtection);
   DISALLOW_COPY_AND_ASSIGN(ExtensionService);
 };
 
 #endif  // CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_