Enable sync for the settings from the Extension Settings API.

chrome/browser/extensions/extension_service.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_service.h"
 
 #include <algorithm>
 #include <set>
 
 #include "base/basictypes.h"
@@ skipping 632 matching lines @@
   omnibox_popup_icon_manager_.set_monochrome(true);
   omnibox_icon_manager_.set_monochrome(true);
   omnibox_icon_manager_.set_padding(gfx::Insets(0, kOmniboxIconPaddingLeft,
                                                 0, kOmniboxIconPaddingRight));
 
   // How long is the path to the Extensions directory?
   UMA_HISTOGRAM_CUSTOM_COUNTS("Extensions.ExtensionRootPathLength",
                               install_directory_.value().length(), 0, 500, 100);
 }
 
+static void AddAllExtensionIds(

[Ben Olmstead, 2011/09/16 18:21:43]

Wrap in anonymous namespace.

[not at google - send to devlin, 2011/09/19 07:10:47]

No longer needed.

+    std::vector<std::string>* dst, const ExtensionList& src) {

[akalin, 2011/09/17 08:44:47]

i think output args are usually put last

[not at google - send to devlin, 2011/09/19 07:10:47]

No longer needed.

+  for (ExtensionList::const_iterator it = src.begin(); it != src.end(); ++it) {
+    dst->push_back((*it)->id());
+  }
+}
+
+const std::vector<std::string> ExtensionService::GetAllExtensionIds() const {
+  std::vector<std::string> all_extension_ids;
+  AddAllExtensionIds(&all_extension_ids, extensions_);
+  AddAllExtensionIds(&all_extension_ids, disabled_extensions_);
+  AddAllExtensionIds(&all_extension_ids, terminated_extensions_);
+  return all_extension_ids;
+}
+
 const ExtensionList* ExtensionService::extensions() const {
   return &extensions_;
 }
 
 const ExtensionList* ExtensionService::disabled_extensions() const {
   return &disabled_extensions_;
 }
 
 const ExtensionList* ExtensionService::terminated_extensions() const {
   return &terminated_extensions_;
@@ skipping 1216 matching lines @@
       sync_data_list->push_back(
           ExtensionSyncData(extension,
                             IsExtensionEnabled(extension.id()),
                             IsIncognitoEnabled(extension.id())));
     }
   }
 }
 
 std::vector<ExtensionSyncData> ExtensionService::GetSyncDataList(
     const SyncBundle& bundle) const {
   std::vector<ExtensionSyncData> extension_sync_list;

[akalin, 2011/09/17 08:44:47]

rewrite this fn using GetAllExtensionIds() and GetInstalledExtension() instead
of GetSyncDataListHelper.

   GetSyncDataListHelper(extensions_, bundle, &extension_sync_list);
   GetSyncDataListHelper(disabled_extensions_, bundle, &extension_sync_list);
   GetSyncDataListHelper(terminated_extensions_, bundle, &extension_sync_list);
 
   for (std::map<std::string, ExtensionSyncData>::const_iterator i =
            bundle.pending_sync_data.begin();
        i != bundle.pending_sync_data.end();
        ++i) {
     extension_sync_list.push_back(i->second);
   }
@@ skipping 971 matching lines @@
 
 ExtensionService::NaClModuleInfoList::iterator
     ExtensionService::FindNaClModule(const GURL& url) {
   for (NaClModuleInfoList::iterator iter = nacl_module_list_.begin();
        iter != nacl_module_list_.end(); ++iter) {
     if (iter->url == url)
       return iter;
   }
   return nacl_module_list_.end();
 }