[cros] check for updates in WebUI OOBE can be cancelled in dev builds.

[cros] check for updates in WebUI OOBE can be cancelled in dev builds.

BUG=chromium-os:18464
TEST=Manual: pressing ESC on OOBE update screen cancels update check.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98801

[whywhat, 2011-08-29 17:55:51]

LGTM

http://codereview.chromium.org/7774009/diff/2001/chrome/app/generated_resourc...
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/7774009/diff/2001/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:10801: Update cancelled...
nit: en-US version is "canceled" with one l.
I think it's better be "Canceling update" since it shows that canceling the
update is a process which takes time.

http://codereview.chromium.org/7774009/diff/2001/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/update_screen.h (right):

http://codereview.chromium.org/7774009/diff/2001/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/update_screen.h:38: virtual void CancelUpdate();
nit: We append OVERRIDE for each new virtual method redefinition.

http://codereview.chromium.org/7774009/diff/2001/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/update_screen_actor.h (right):

http://codereview.chromium.org/7774009/diff/2001/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/update_screen_actor.h:23: virtual
~UpdateScreenActor() {}
nit: I think we'd better notify the screen that we're destroyed here.

http://codereview.chromium.org/7774009/diff/2001/chrome/browser/resources/chr...
File chrome/browser/resources/chromeos/login/oobe.css (right):

http://codereview.chromium.org/7774009/diff/2001/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/login/oobe.css:281: #update
#update-cancel-hint {
Maybe just div's id is enough?

http://codereview.chromium.org/7774009/diff/2001/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/login/oobe.css:283: margin: 1em -16em;
nit: please, sort properties alphabetically

http://codereview.chromium.org/7774009/diff/2001/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/login/oobe.css:285: color: #aa0000;
nit: #a00

[Ivan Korotkov, 2011-08-29 18:19:17]

http://codereview.chromium.org/7774009/diff/2001/chrome/app/generated_resourc...
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/7774009/diff/2001/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:10801: Update cancelled...
Changed to 'Cancelling update...'

http://codereview.chromium.org/7774009/diff/2001/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/update_screen.h (right):

http://codereview.chromium.org/7774009/diff/2001/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/update_screen.h:38: virtual void CancelUpdate();
On 2011/08/29 17:55:51, whywhat wrote:
> nit: We append OVERRIDE for each new virtual method redefinition.

Done.

http://codereview.chromium.org/7774009/diff/2001/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/update_screen_actor.h (right):

http://codereview.chromium.org/7774009/diff/2001/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/update_screen_actor.h:23: virtual
~UpdateScreenActor() {}
On 2011/08/29 17:55:51, whywhat wrote:
> nit: I think we'd better notify the screen that we're destroyed here.

Other actors with delegates (like UserImageScreenActor) don't do it, what for?
However, ~UpdateScreen() should set actor's delegate to NULL, fixed.

http://codereview.chromium.org/7774009/diff/2001/chrome/browser/resources/chr...
File chrome/browser/resources/chromeos/login/oobe.css (right):

http://codereview.chromium.org/7774009/diff/2001/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/login/oobe.css:281: #update
#update-cancel-hint {
On 2011/08/29 17:55:51, whywhat wrote:
> Maybe just div's id is enough?

Won't override '#update div' then.

http://codereview.chromium.org/7774009/diff/2001/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/login/oobe.css:283: margin: 1em -16em;
On 2011/08/29 17:55:51, whywhat wrote:
> nit: please, sort properties alphabetically

Done.

http://codereview.chromium.org/7774009/diff/2001/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/login/oobe.css:285: color: #aa0000;
On 2011/08/29 17:55:51, whywhat wrote:
> nit: #a00

Done.

[commit-bot: I haz the power, 2011-08-30 09:29:49]

Try job failure for 7774009-11001 on win for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2011-08-30 10:51:48]

Change committed as 98801