Issue 7774004: Revert 98552 (OpenAndManuallyCloseDevToolsClientHost now fails on

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7774004: Revert 98552 (OpenAndManuallyCloseDevToolsClientHost now fails on (Closed)

Created:
9 years, 3 months ago by Nico

Modified:
9 years, 3 months ago

Reviewers:
yurys

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 98552 (OpenAndManuallyCloseDevToolsClientHost now fails on several bots, like the trybots hinted it will) - DevTools: introduce DevToolsAgentHost We need an abstract interface that would encapsulate communication with inspected instance's DevTools agent. It is going to have different implementations at least for render views and shared workers. This patch leaves all methods on the DevToolsManager that accept inspected RenderViewHost just for convenience. Eventually DevToolsManager should operate in terms of DevToolsAgentHost and DevToolsClientHost only. BUG=None TEST=DevTools tests Review URL: http://codereview.chromium.org/7719026 TBR=yurys@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98554

Patch Set 1 #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+118 lines, -300 lines)			Patch
D	content/browser/debugger/devtools_agent_host.h	View	1 chunk	+0 lines, -44 lines	0 comments	Download
D	content/browser/debugger/devtools_agent_host.cc	View	1 chunk	+0 lines, -18 lines	0 comments	Download
M	content/browser/debugger/devtools_manager.h	View	6 chunks	+23 lines, -24 lines	0 comments	Download
M	content/browser/debugger/devtools_manager.cc	View	10 chunks	+95 lines, -106 lines	0 comments	Download
D	content/browser/debugger/render_view_devtools_agent_host.h	View	1 chunk	+0 lines, -46 lines	0 comments	Download
D	content/browser/debugger/render_view_devtools_agent_host.cc	View	1 chunk	+0 lines, -58 lines	0 comments	Download
M	content/content_browser.gypi	View	2 chunks	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

On 2011/08/27 06:02:49, Nico wrote:

lgtm

Expand Messages | Collapse Messages