Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 7773001: Add regression test for the parallel jobs dependency issue. (Closed)

Created:
9 years, 4 months ago by M-A Ruel
Modified:
9 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, Dirk Pranke, M-A Ruel
Visibility:
Public.

Description

Add regression test for the parallel jobs dependency issue. Well, the funny thing is that it doesn't find the bug but the framework is already good enough as-is to be worth checked-in, so the next commit can show the relevant difference. R=dpranke@chromium.org BUG=60725 TEST= Committed: 98869

Patch Set 1 #

Patch Set 2 : add comment #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -0 lines) Patch
A tests/gclient_test.py View 1 1 chunk +167 lines, -0 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
M-A Ruel
9 years, 4 months ago (2011-08-27 01:46:08 UTC) #1
Dirk Pranke
Can you add some more comments describing what you're testing and verifying? I fear that ...
9 years, 3 months ago (2011-08-29 20:53:28 UTC) #2
M-A Ruel
http://codereview.chromium.org/7773001/diff/3001/tests/gclient_test.py File tests/gclient_test.py (right): http://codereview.chromium.org/7773001/diff/3001/tests/gclient_test.py#newcode85 tests/gclient_test.py:85: # Verify that dependencies are processed in the right ...
9 years, 3 months ago (2011-08-30 15:07:34 UTC) #3
Dirk Pranke
9 years, 3 months ago (2011-08-30 20:34:54 UTC) #4
LGTM.

Powered by Google App Engine
This is Rietveld 408576698