gfx::Compositor: SchedulePaint.

ui/gfx/compositor/compositor.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_GFX_COMPOSITOR_COMPOSITOR_H_
 #define UI_GFX_COMPOSITOR_COMPOSITOR_H_
 #pragma once
 
 #include "base/memory/ref_counted.h"
 #include "ui/gfx/compositor/compositor_export.h"
@@ skipping 45 matching lines @@
   virtual void Draw(const ui::TextureDrawParams& params,
                     const gfx::Rect& clip_bounds_in_texture) = 0;
 
  protected:
   virtual ~Texture() {}
 
  private:
   friend class base::RefCounted<Texture>;
 };
 
+// An interface to allow the compositor to communicate with its owner.
+class COMPOSITOR_EXPORT CompositorOwner {

[sky, 2011/09/06 17:39:01]

Call this CompositorDelegate

[sadrul, 2011/09/06 18:13:23]

Done.

+ public:
+  // Returns the AcceleratedWidget the compositor should paint onto.
+  virtual gfx::AcceleratedWidget GetAcceleratedWidget() = 0;

[sky, 2011/09/06 17:39:01]

I prefer passing this into the constructor rather than having to query the
delegate for it.

[sadrul, 2011/09/06 18:13:23]

Done.

+
+  // Refreshes the textures. The Compositor calls this after a SchedulePaint.

[sky, 2011/09/06 17:39:01]

I don't like having yet another paint coalescing code path.
How about instead of delegating PaintNow, we delegate the schedule. That is,
SchedulePaint becomes:
void SchedulePaint() {
  delegate_->ScheduleCompositorPaint();
}
?

[sadrul, 2011/09/06 18:13:23]

Sounds like a good plan. Done.

+  virtual void PaintNow() = 0;
+};
+
 // Compositor object to take care of GPU painting.
 // A Browser compositor object is responsible for generating the final
 // displayable form of pixels comprising a single widget's contents. It draws an
 // appropriately transformed texture for each transformed view in the widget's
 // view hierarchy.
 class COMPOSITOR_EXPORT Compositor : public base::RefCounted<Compositor> {
  public:
   // Create a compositor from the provided handle.
-  static Compositor* Create(gfx::AcceleratedWidget widget,
+  static Compositor* Create(CompositorOwner* owner,
                             const gfx::Size& size);
 
   // Creates a new texture. The caller owns the returned object.
   virtual Texture* CreateTexture() = 0;
 
   // Notifies the compositor that compositing is about to start.
   virtual void NotifyStart() = 0;
 
   // Notifies the compositor that compositing is complete.
   virtual void NotifyEnd() = 0;
 
   // Blurs the specific region in the compositor.
   virtual void Blur(const gfx::Rect& bounds) = 0;
 
   // Schedules a paint on the widget this Compositor was created for.
   virtual void SchedulePaint() = 0;
 
   // Notifies the compositor that the size of the widget that it is
   // drawing to has changed.
   void WidgetSizeChanged(const gfx::Size& size) {
     size_ = size;
     OnWidgetSizeChanged();
   }
 
   // Returns the size of the widget that is being drawn to.
   const gfx::Size& size() { return size_; }
 
  protected:
-  explicit Compositor(const gfx::Size& size) : size_(size) {}
+  Compositor(CompositorOwner* owner, const gfx::Size& size)
+      : owner_(owner),
+        size_(size) {}
   virtual ~Compositor() {}
 
   virtual void OnWidgetSizeChanged() = 0;
 
+  CompositorOwner* owner() { return owner_; }
+
  private:
+  CompositorOwner* owner_;
   gfx::Size size_;
 
   friend class base::RefCounted<Compositor>;
 };
 
 }  // namespace ui
 
 #endif  // UI_GFX_COMPOSITOR_COMPOSITOR_H_