Update existing suppression given code changes to IPC message dispatch.

Update existing suppression given code changes to IPC message dispatch.

TBR=timurrrr@chromium.org
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98519

[darin (slow to review), 2011-08-26 23:30:47]

Based on this report:
http://build.chromium.org/p/chromium.memory/builders/Linux%20Tests%20%28valgr...

[darin (slow to review), 2011-08-26 23:33:12]

I'm a bit surprised by the way that this is the only suppression I needed to
change.  I would expect that any suppression that mentions MessageWithTuple
or MessageWithReply will need to be changed or deleted.

-Darin

On Fri, Aug 26, 2011 at 4:30 PM, <darin@chromium.org> wrote:

> Reviewers: Timur Iskhodzhanov,
>
> Message:
> Based on this report:
> http://build.chromium.org/p/**chromium.memory/builders/**
> Linux%20Tests%20%28valgrind%**29%282%29/builds/4054/steps/**
>
memory%20test%3A%20ui/logs/**stdio<http://build.chromium.org/p/chromium.memory/builders/Linux%20Tests%20%28valgrind%29%282%29/builds/4054/steps/memory%20test%3A%20ui/logs/stdio>
>
> Description:
> Update existing suppression given code changes to IPC message dispatch.
>
> Please review this at
http://codereview.chromium.**org/7767009/<http://codereview.chromium.org/7767...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src/<http://svn.chromium.org/chrome/trunk/src/>
>
> Affected files:
>  M     tools/valgrind/memcheck/**suppressions.txt
>
>
> Index: tools/valgrind/memcheck/**suppressions.txt
> ==============================**==============================**=======
> --- tools/valgrind/memcheck/**suppressions.txt    (revision 98518)
> +++ tools/valgrind/memcheck/**suppressions.txt    (working copy)
> @@ -3466,7 +3466,8 @@
>    Memcheck:Leak
>    fun:_Znw*
>    fun:_**ZN3IPC11SyncMessage13GenerateR**eplyEPKNS_7MessageE
> -   fun:_**ZN3IPC16MessageWithReplyI6Tupl**e1I21PluginMsg_Init_ParamsES1_*
> *IRbEE18DispatchDelayReplyIN13P**luginChannel13MessageFilterEMS**
> 9_FvRKS2_PNS_**7MessageEEEEbPKSC_PT_T0_
> +   fun:_**ZN3IPC17SyncMessageSchemaI6Tup**le1I21PluginMsg_Init_**
> ParamsES1_**IRbEE32DispatchDelayReplyWithS**endParamsIN13PluginChannel13Me
> **ssageFilterEMS9_FvRKS2_PNS_**7MessageEEEEbbRKS3_PKSC_PT_T0_
> +   fun:_ZN14PluginMsg_**Init18DispatchDelayReplyIN13Pl**
> uginChannel13MessageFilterEMS2**_FvRK21PluginMsg_Init_**
> ParamsPN3IPC7MessageEEEEbPKS7_**PT_T0_
>    fun:_**ZN13PluginChannel13MessageFilt**er17OnMessageReceivedERKN3IPC7**
> MessageE
>  }
>  {
>
>
>

[oshima, 2011-08-27 00:39:31]

On 2011/08/26 23:33:12, darin wrote:
> I'm a bit surprised by the way that this is the only suppression I needed to
> change.  I would expect that any suppression that mentions MessageWithTuple
> or MessageWithReply will need to be changed or deleted.'

Thank you for taking care of this.

There seems to be more coming that are related. I'll update them.
- oshima
> 
> -Darin
> 
> On Fri, Aug 26, 2011 at 4:30 PM, <mailto:darin@chromium.org> wrote:
> 
> > Reviewers: Timur Iskhodzhanov,
> >
> > Message:
> > Based on this report:
> > http://build.chromium.org/p/**chromium.memory/builders/**
> > Linux%20Tests%20%28valgrind%**29%282%29/builds/4054/steps/**
> >
>
memory%20test%3A%20ui/logs/**stdio<http://build.chromium.org/p/chromium.memory/builders/Linux%20Tests%20%28valgrind%29%282%29/builds/4054/steps/memory%20test%3A%20ui/logs/stdio>
> >
> > Description:
> > Update existing suppression given code changes to IPC message dispatch.
> >
> > Please review this at
>
http://codereview.chromium.**org/7767009/%3Chttp://codereview.chromium.org/77...>
> >
> > SVN Base:
>
svn://svn.chromium.org/chrome/**trunk/src/<http://svn.chromium.org/chrome/trunk/src/>
> >
> > Affected files:
> >  M     tools/valgrind/memcheck/**suppressions.txt
> >
> >
> > Index: tools/valgrind/memcheck/**suppressions.txt
> > ==============================**==============================**=======
> > --- tools/valgrind/memcheck/**suppressions.txt    (revision 98518)
> > +++ tools/valgrind/memcheck/**suppressions.txt    (working copy)
> > @@ -3466,7 +3466,8 @@
> >    Memcheck:Leak
> >    fun:_Znw*
> >    fun:_**ZN3IPC11SyncMessage13GenerateR**eplyEPKNS_7MessageE
> > -   fun:_**ZN3IPC16MessageWithReplyI6Tupl**e1I21PluginMsg_Init_ParamsES1_*
> > *IRbEE18DispatchDelayReplyIN13P**luginChannel13MessageFilterEMS**
> > 9_FvRKS2_PNS_**7MessageEEEEbPKSC_PT_T0_
> > +   fun:_**ZN3IPC17SyncMessageSchemaI6Tup**le1I21PluginMsg_Init_**
> > ParamsES1_**IRbEE32DispatchDelayReplyWithS**endParamsIN13PluginChannel13Me
> > **ssageFilterEMS9_FvRKS2_PNS_**7MessageEEEEbbRKS3_PKSC_PT_T0_
> > +   fun:_ZN14PluginMsg_**Init18DispatchDelayReplyIN13Pl**
> > uginChannel13MessageFilterEMS2**_FvRK21PluginMsg_Init_**
> > ParamsPN3IPC7MessageEEEEbPKS7_**PT_T0_
> >    fun:_**ZN13PluginChannel13MessageFilt**er17OnMessageReceivedERKN3IPC7**
> > MessageE
> >  }
> >  {
> >
> >
> >

[Timur Iskhodzhanov, 2011-08-29 13:27:51]

On 2011/08/27 00:39:31, oshima wrote:
> Thank you for taking care of this.
> 
> There seems to be more coming that are related. I'll update them.
> - oshima
Giving a rubber-stamp LGTM assuming Mitsuru has taken care of the other
assertions.

Thanks!