Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(699)

Unified Diff: content/common/native_web_keyboard_event.h

Issue 7766012: Move native_web_keyboard_event_views.cc to chrome, so that we don't have any views code in conten... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Get rid of the views constructor in content as well Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/native_web_keyboard_event_views.cc ('k') | content/common/native_web_keyboard_event_views.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/native_web_keyboard_event.h
===================================================================
--- content/common/native_web_keyboard_event.h (revision 98479)
+++ content/common/native_web_keyboard_event.h (working copy)
@@ -22,12 +22,6 @@
typedef struct _GdkEventKey GdkEventKey;
#endif
-#if defined(TOOLKIT_VIEWS)
-namespace views {
-class KeyEvent;
-}
-#endif
-
// Owns a platform specific event; used to pass own and pass event through
// platform independent code.
struct NativeWebKeyboardEvent : public WebKit::WebKeyboardEvent {
@@ -51,21 +45,6 @@
double time_stamp_seconds);
#endif
-#if defined(TOOLKIT_VIEWS)
- // TODO(suzhe): remove once we get rid of Gtk from Views.
- struct FromViewsEvent {};
- // These two constructors are shared between Windows and Linux Views ports.
- explicit NativeWebKeyboardEvent(const views::KeyEvent& event);
- // TODO(suzhe): Sadly, we need to add a meanless FromViewsEvent parameter to
- // distinguish between this contructor and above Gtk one, because they use
- // different modifier flags. We can remove this extra parameter as soon as we
- // disable above Gtk constructor in Linux Views port.
- NativeWebKeyboardEvent(uint16 character,
- int flags,
- double time_stamp_seconds,
- FromViewsEvent);
-#endif
-
NativeWebKeyboardEvent(const NativeWebKeyboardEvent& event);
~NativeWebKeyboardEvent();
« no previous file with comments | « chrome/common/native_web_keyboard_event_views.cc ('k') | content/common/native_web_keyboard_event_views.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698