Issue 7766012: Move native_web_keyboard_event_views.cc to chrome, so that we don't have any views code in conten...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7766012: Move native_web_keyboard_event_views.cc to chrome, so that we don't have any views code in conten... (Closed)

Created:
9 years, 4 months ago by jam

Modified:
9 years, 3 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Move native_web_keyboard_event_views.cc to chrome, so that we don't have any views code in content. Although this is now away from the other NativeWebKeyboardEvent implementations, it's at least in the same module as the rest of the views related implementations like RenderWidgetHostViewViews and TabContentViewViews which use it. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98570

Patch Set 1 : '' #

Patch Set 2 : Get rid of the views constructor in content as well #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -127 lines)			Patch
M	chrome/browser/renderer_host/render_widget_host_view_views.cc	View	1	3 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/chrome_common.gypi	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
A	chrome/common/native_web_keyboard_event_views.h	View	1	1 chunk	+33 lines, -0 lines	0 comments	Download
A +	chrome/common/native_web_keyboard_event_views.cc	View	1	4 chunks	+14 lines, -9 lines	0 comments	Download
M	content/common/native_web_keyboard_event.h	View	1	2 chunks	+0 lines, -21 lines	0 comments	Download
D	content/common/native_web_keyboard_event_views.cc	View		1 chunk	+0 lines, -86 lines	0 comments	Download
M	content/content_common.gypi	View		1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jam

actually, please take another look. I just realized we should also take out the declarations ...

9 years, 4 months ago (2011-08-26 23:33:20 UTC) #3

OK

Expand Messages | Collapse Messages