Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Issue 7766005: Move the parser creation code in its own function to enable unit testing. (Closed)

Created:
9 years, 4 months ago by M-A Ruel
Modified:
9 years, 4 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, Dirk Pranke, M-A Ruel
Visibility:
Public.

Description

Move the parser creation code in its own function to enable unit testing. Unit test follow in next CL. R=dpranke@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98480

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -43 lines) Patch
M gclient.py View 2 chunks +49 lines, -43 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
M-A Ruel
9 years, 4 months ago (2011-08-26 20:19:21 UTC) #1
Dirk Pranke
9 years, 4 months ago (2011-08-26 20:25:44 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698