Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1505)

Unified Diff: gpu/command_buffer/client/gles2_implementation_autogen.h

Issue 7765013: Revert 98504 - Manually merging trunk revs 95836 and 96904 to 835 branch (second attempt) (Closed) Base URL: svn://svn.chromium.org/chrome/branches/835/src/
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/client/gles2_implementation_autogen.h
===================================================================
--- gpu/command_buffer/client/gles2_implementation_autogen.h (revision 98533)
+++ gpu/command_buffer/client/gles2_implementation_autogen.h (working copy)
@@ -221,6 +221,8 @@
return;
}
DeleteBuffersHelper(n, buffers);
+ helper_->DeleteBuffersImmediate(n, buffers);
+ Flush();
}
void DeleteFramebuffers(GLsizei n, const GLuint* framebuffers) {
@@ -240,12 +242,16 @@
return;
}
DeleteFramebuffersHelper(n, framebuffers);
+ helper_->DeleteFramebuffersImmediate(n, framebuffers);
+ Flush();
}
void DeleteProgram(GLuint program) {
GPU_CLIENT_LOG("[" << this << "] glDeleteProgram(" << program << ")");
GPU_CLIENT_DCHECK(program != 0);
- DeleteProgramHelper(program);
+ program_and_shader_id_handler_->FreeIds(1, &program);
+ helper_->DeleteProgram(program);
+ Flush();
}
void DeleteRenderbuffers(GLsizei n, const GLuint* renderbuffers) {
@@ -265,12 +271,16 @@
return;
}
DeleteRenderbuffersHelper(n, renderbuffers);
+ helper_->DeleteRenderbuffersImmediate(n, renderbuffers);
+ Flush();
}
void DeleteShader(GLuint shader) {
GPU_CLIENT_LOG("[" << this << "] glDeleteShader(" << shader << ")");
GPU_CLIENT_DCHECK(shader != 0);
- DeleteShaderHelper(shader);
+ program_and_shader_id_handler_->FreeIds(1, &shader);
+ helper_->DeleteShader(shader);
+ Flush();
}
void DeleteTextures(GLsizei n, const GLuint* textures) {
@@ -290,6 +300,8 @@
return;
}
DeleteTexturesHelper(n, textures);
+ helper_->DeleteTexturesImmediate(n, textures);
+ Flush();
}
void DepthFunc(GLenum func) {
@@ -559,20 +571,19 @@
<< static_cast<void*>(infolog) << ")");
helper_->SetBucketSize(kResultBucketId, 0);
helper_->GetProgramInfoLog(program, kResultBucketId);
- std::string str;
- GLsizei max_size = 0;
- if (GetBucketAsString(kResultBucketId, &str)) {
- if (bufsize > 0) {
- max_size =
+ if (bufsize > 0) {
+ std::string str;
+ if (GetBucketAsString(kResultBucketId, &str)) {
+ GLsizei max_size =
std::min(static_cast<size_t>(bufsize) - 1, str.size());
+ if (length != NULL) {
+ *length = max_size;
+ }
memcpy(infolog, str.c_str(), max_size);
infolog[max_size] = '\0';
GPU_CLIENT_LOG("------\n" << infolog << "\n------");
}
}
- if (length != NULL) {
- *length = max_size;
- }
}
void GetRenderbufferParameteriv(GLenum target, GLenum pname, GLint* params) {
GPU_CLIENT_VALIDATE_DESTINATION_INITALIZATION(GLint, params);
@@ -622,20 +633,19 @@
<< static_cast<void*>(infolog) << ")");
helper_->SetBucketSize(kResultBucketId, 0);
helper_->GetShaderInfoLog(shader, kResultBucketId);
- std::string str;
- GLsizei max_size = 0;
- if (GetBucketAsString(kResultBucketId, &str)) {
- if (bufsize > 0) {
- max_size =
+ if (bufsize > 0) {
+ std::string str;
+ if (GetBucketAsString(kResultBucketId, &str)) {
+ GLsizei max_size =
std::min(static_cast<size_t>(bufsize) - 1, str.size());
+ if (length != NULL) {
+ *length = max_size;
+ }
memcpy(infolog, str.c_str(), max_size);
infolog[max_size] = '\0';
GPU_CLIENT_LOG("------\n" << infolog << "\n------");
}
}
- if (length != NULL) {
- *length = max_size;
- }
}
void GetShaderPrecisionFormat(
GLenum shadertype, GLenum precisiontype, GLint* range, GLint* precision);
@@ -650,20 +660,19 @@
<< static_cast<void*>(source) << ")");
helper_->SetBucketSize(kResultBucketId, 0);
helper_->GetShaderSource(shader, kResultBucketId);
- std::string str;
- GLsizei max_size = 0;
- if (GetBucketAsString(kResultBucketId, &str)) {
- if (bufsize > 0) {
- max_size =
+ if (bufsize > 0) {
+ std::string str;
+ if (GetBucketAsString(kResultBucketId, &str)) {
+ GLsizei max_size =
std::min(static_cast<size_t>(bufsize) - 1, str.size());
+ if (length != NULL) {
+ *length = max_size;
+ }
memcpy(source, str.c_str(), max_size);
source[max_size] = '\0';
GPU_CLIENT_LOG("------\n" << source << "\n------");
}
}
- if (length != NULL) {
- *length = max_size;
- }
}
const GLubyte* GetString(GLenum name);
@@ -800,7 +809,10 @@
helper_->LineWidth(width);
}
-void LinkProgram(GLuint program);
+void LinkProgram(GLuint program) {
+ GPU_CLIENT_LOG("[" << this << "] glLinkProgram(" << program << ")");
+ helper_->LinkProgram(program);
+}
void PixelStorei(GLenum pname, GLint param);
« no previous file with comments | « gpu/command_buffer/client/gles2_implementation.cc ('k') | gpu/command_buffer/client/gles2_implementation_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698