Allow both Context3D and Graphics3D with the video decoder

Allow both Context3D and Graphics3D with the video decoder

BUG=none
TEST=Pepper Flash


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98742

[vrk (LEFT CHROMIUM), 2011-08-29 16:56:41]

LGTM with a few suggestions

http://codereview.chromium.org/7765011/diff/1/ppapi/cpp/dev/video_decoder_dev.h
File ppapi/cpp/dev/video_decoder_dev.h (right):

http://codereview.chromium.org/7765011/diff/1/ppapi/cpp/dev/video_decoder_dev...
ppapi/cpp/dev/video_decoder_dev.h:31: explicit VideoDecoder_Dev(const Instance&
instance,
Drop the "explicit" here and above

http://codereview.chromium.org/7765011/diff/1/ppapi/proxy/ppb_video_decoder_p...
File ppapi/proxy/ppb_video_decoder_proxy.cc (right):

http://codereview.chromium.org/7765011/diff/1/ppapi/proxy/ppb_video_decoder_p...
ppapi/proxy/ppb_video_decoder_proxy.cc:232:
EnterResourceNoLock<PPB_Graphics3D_API> enter_context(context3d_id, true);
nit: "context3d_id" is a bit of a misleading name for this argument now, as the
identifier may be referring to a Graphics3D resource instead of a Context3D
resource. 

Rename to something more general here and elsewhere (including shared_impl and
webkit)? Up to you.

[piman, 2011-08-29 19:58:57]

http://codereview.chromium.org/7765011/diff/1/ppapi/cpp/dev/video_decoder_dev.h
File ppapi/cpp/dev/video_decoder_dev.h (right):

http://codereview.chromium.org/7765011/diff/1/ppapi/cpp/dev/video_decoder_dev...
ppapi/cpp/dev/video_decoder_dev.h:31: explicit VideoDecoder_Dev(const Instance&
instance,
On 2011/08/29 16:56:41, Victoria Kirst wrote:
> Drop the "explicit" here and above

Done.

http://codereview.chromium.org/7765011/diff/1/ppapi/proxy/ppb_video_decoder_p...
File ppapi/proxy/ppb_video_decoder_proxy.cc (right):

http://codereview.chromium.org/7765011/diff/1/ppapi/proxy/ppb_video_decoder_p...
ppapi/proxy/ppb_video_decoder_proxy.cc:232:
EnterResourceNoLock<PPB_Graphics3D_API> enter_context(context3d_id, true);
On 2011/08/29 16:56:41, Victoria Kirst wrote:
> nit: "context3d_id" is a bit of a misleading name for this argument now, as
the
> identifier may be referring to a Graphics3D resource instead of a Context3D
> resource. 
> 
> Rename to something more general here and elsewhere (including shared_impl and
> webkit)? Up to you.

I renamed to graphics_context. I really want to name it 3d_context, but that's
not a valid identifier name.

[commit-bot: I haz the power, 2011-08-30 00:48:41]

Change committed as 98742