Issue 7764014: Remove handling for the ViewHostMsg_GetCookies and ViewHostMsg_SetCookies from Chrome. These mess...

Issue 7764014: Remove handling for the ViewHostMsg_GetCookies and ViewHostMsg_SetCookies from Chrome. These mess... (Closed)

Created:
9 years, 3 months ago by ananta

Modified:
9 years, 3 months ago

Reviewers:
jam

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Remove handling for the ViewHostMsg_GetCookies and ViewHostMsg_SetCookies from Chrome. These messages were being handled in Chrome only for ChromeFrame processes, i.e. to route the cookie requests to the host browser. We now send out the ChromeViewHostMsg_GetCookies and ChromeViewHostMsg_SetCookies IPCs for ChromeFrame processes. These are sent out by the embedder instance which lives in the renderer. ChromeRenderMessageFilter handles these messages. This is a continuation of the changes to not handle IPC messages from content in Chrome and vice versa. BUG=87335 TEST=No change in functionality. chrome frame net tests and chrome frame tests should pass. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98735

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Total comments: 4

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Patch Set 9 : '' #

Patch Set 10 : '' #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+122 lines, -14 lines)			Patch
M	chrome/browser/automation/automation_resource_message_filter.cc	View	1 2 3 4 5	2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/renderer_host/chrome_render_message_filter.cc	View	1 2 3 4 5 6 7 8 9	1 chunk	+5 lines, -4 lines	0 comments	Download
M	chrome/common/render_messages.h	View	1 2 3 4 5	1 chunk	+16 lines, -0 lines	0 comments	Download
M	chrome/renderer/chrome_content_renderer_client.h	View	1 2 3 4 5 6 7	2 chunks	+10 lines, -0 lines	0 comments	Download
M	chrome/renderer/chrome_content_renderer_client.cc	View	1 2 3 4 5 6 7 8	2 chunks	+30 lines, -0 lines	0 comments	Download
M	content/renderer/content_renderer_client.h	View	1 2 3 4 5 6 7	2 chunks	+15 lines, -0 lines	0 comments	Download
M	content/renderer/mock_content_renderer_client.h	View	1 2 3 4 5 6 7	2 chunks	+10 lines, -0 lines	0 comments	Download
M	content/renderer/mock_content_renderer_client.cc	View	1 2 3 4 5 6 7	1 chunk	+15 lines, -0 lines	0 comments	Download
M	content/renderer/renderer_webcookiejar_impl.h	View	1 2 3 4 5 6 7	3 chunks	+4 lines, -3 lines	0 comments	Download
M	content/renderer/renderer_webcookiejar_impl.cc	View	1 2 3 4 5	2 chunks	+14 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jam

http://codereview.chromium.org/7764014/diff/2005/content/renderer/content_renderer_client.h File content/renderer/content_renderer_client.h (right): http://codereview.chromium.org/7764014/diff/2005/content/renderer/content_renderer_client.h#newcode113 content/renderer/content_renderer_client.h:113: // Return true if the GetCookie request can be ...

9 years, 3 months ago (2011-08-28 21:44:42 UTC) #2

ananta

9 years, 3 months ago (2011-08-29 19:12:25 UTC) #3

lgtm

sorry about the confusion, RenderView is good.

Expand Messages | Collapse Messages