Issue 7764013: ntp4: fix app load/unload race condition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7764013: ntp4: fix app load/unload race condition (Closed)

Created:
9 years, 4 months ago by Evan Stade

Modified:
9 years, 3 months ago

Reviewers:
csilv, commit-bot: I haz the power

CC:
chromium-reviews, estade+watch_chromium.org, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

ntp4: fix app load/unload race condition BUG=94095 TEST=open ntp and chrome://extensions, spam disable/enable on something that's both an app and an extension (such as weatherbug). NTP should not start creating multiple copies of the icon. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98685

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -5 lines)			Patch
M	chrome/browser/resources/ntp4/apps_page.js	View	1 chunk	+12 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/ntp4/new_tab.js	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/browser/resources/ntp4/tile_page.js	View	2 chunks	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Change committed as 98685

Expand Messages | Collapse Messages