File Manager: Assorted fixes and polish

chrome/browser/resources/file_manager/js/file_manager.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Setting the src of an img to an empty string can crash the browser, so we
 // use an empty 1x1 gif instead.
 const EMPTY_IMAGE_URI = 'data:image/gif;base64,'
         + 'R0lGODlhAQABAPABAP///wAAACH5BAEKAAAALAAAAAABAAEAAAICRAEAOw%3D%3D';
 
 var g_slideshow_data = null;
@@ skipping 1600 matching lines @@
     this[methodName].apply(this, data.arguments);
   };
 
   /**
    * Callback called when tasks for selected files are determined.
    * @param {Object} selection Selection is passed here, since this.selection
    *     can change before tasks were found, and we should be accurate.
    * @param {Array.<Task>} tasksList The tasks list.
    */
   FileManager.prototype.onTasksFound_ = function(selection, tasksList) {
+    this.taskButtons_.innerHTML = '';
+
     for (var i = 0; i < tasksList.length; i++) {
       var task = tasksList[i];
 
       // Tweak images, titles of internal tasks.
       var task_parts = task.taskId.split('|');
       if (task_parts[0] == this.getExtensionId_()) {
         if (task_parts[1] == 'preview') {
           // TODO(serya): This hack needed until task.iconUrl get working
           //              (see GetFileTasksFileBrowserFunction::RunImpl).
           task.iconUrl =
@@ skipping 15 matching lines @@
         } else if (task_parts[1] == 'mount-archive') {
           task.iconUrl =
               chrome.extension.getURL('images/icon_mount_archive_16x16.png');
           task.title = str('MOUNT_ARCHIVE');
           if (str('ENABLE_ARCHIVES') != 'true')
             continue;
         }
       }
       this.renderTaskButton_(task);
     }
+
+    // These are done in separate functions, as the checks require
+    // asynchronous function calls.
     this.maybeRenderUnmountTask_(selection);
-    // This needs to be done in separate function, as check requires
-    // asynchronous function calls.
     this.maybeRenderFormattingTask_(selection);
   };
 
   FileManager.prototype.renderTaskButton_ = function(task) {
     var button = this.document_.createElement('button');
     button.addEventListener('click', this.onTaskButtonClicked_.bind(this));
     button.className = 'task-button';
     button.task = task;
 
     var img = this.document_.createElement('img');
@@ skipping 763 matching lines @@
         // that are no longer there.
         continue;
       }
 
       if (!event.changes[i].selected) {
         var checkbox = listItem.querySelector('input[type="checkbox"]');
         checkbox.checked = false;
       }
     }
 
-    if (this.selection.fileCount > 1) {
+    if (this.selection.totalCount > 0) {
       // If more than one file is selected, make sure all checkboxes are lit
       // up.
       for (var i = 0; i < this.selection.entries.length; i++) {
-        if (!this.selection.entries[i].isFile)
-          continue;
-
         var selectedIndex = this.selection.indexes[i];
         var listItem = this.currentList_.getListItemByIndex(selectedIndex);
         if (listItem)
           listItem.querySelector('input[type="checkbox"]').checked = true;
       }
     }
   };
 
   FileManager.prototype.updateOkButton_ = function(event) {
     var selectable;
@@ skipping 701 matching lines @@
 
     if (msg) {
       console.log('no no no');
       this.alert.show(msg, onAccept);
       return false;
     }
 
     return true;
   };
 })();