Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 7764011: File Manager: Assorted fixes and polish (Closed)

Created:
9 years, 4 months ago by rginda
Modified:
9 years, 3 months ago
Reviewers:
zel
CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews), achuith+watch_chromium.org
Visibility:
Public.

Description

File Manager: Assorted fixes and polish Add chromeish button style Fix dialog gradient and transitions Fix harness file creation Fix task button rendering Make list header gradient not leak outside of list Show checkmark even when only a single item is selected (multi-select mode only). Add a delay to the mock tasks callback to better simulate the real world. BUG=chromium-os:17028, chromium-os:19373, chromium-os:19693 TEST=manual testing Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98701

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -35 lines) Patch
M chrome/browser/resources/file_manager/css/dialogs.css View 1 chunk +3 lines, -3 lines 1 comment Download
M chrome/browser/resources/file_manager/css/file_manager.css View 4 chunks +65 lines, -12 lines 0 comments Download
M chrome/browser/resources/file_manager/js/dialogs.js View 4 chunks +10 lines, -4 lines 0 comments Download
M chrome/browser/resources/file_manager/js/file_manager.js View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/resources/file_manager/js/harness.js View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/file_manager/js/mock_chrome.js View 1 chunk +3 lines, -1 line 1 comment Download
M chrome/browser/resources/file_manager/js/util.js View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/resources/file_manager/main.html View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 2 (0 generated)
rginda
http://codereview.chromium.org/7764011/diff/1/chrome/browser/resources/file_manager/css/dialogs.css File chrome/browser/resources/file_manager/css/dialogs.css (right): http://codereview.chromium.org/7764011/diff/1/chrome/browser/resources/file_manager/css/dialogs.css#newcode15 chrome/browser/resources/file_manager/css/dialogs.css:15: background: -webkit-radial-gradient(rgba(127, 127, 127, 0.5), Background gradient copied from ...
9 years, 4 months ago (2011-08-26 22:41:03 UTC) #1
zel
9 years, 4 months ago (2011-08-27 00:09:41 UTC) #2
LGTM

http://codereview.chromium.org/7764011/diff/1/chrome/browser/resources/file_m...
File chrome/browser/resources/file_manager/main.html (right):

http://codereview.chromium.org/7764011/diff/1/chrome/browser/resources/file_m...
chrome/browser/resources/file_manager/main.html:141: <center><img
class=preview-img></center>
we should center in CSS instead

Powered by Google App Engine
This is Rietveld 408576698