Issue 7764010: Get rid of last views dependency in RenderWidgetHostViewWin.

Issue 7764010: Get rid of last views dependency in RenderWidgetHostViewWin. (Closed)

Created:
9 years, 4 months ago by jam

Modified:
9 years, 3 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, dhollowa

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Get rid of last views dependency in RenderWidgetHostViewWin. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98569

Patch Set 1 #

Total comments: 4

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -22 lines)			Patch
M	content/browser/DEPS	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_gtk.cc	View	2 chunks	+0 lines, -4 lines	1 comment	Download
M	content/browser/renderer_host/render_widget_host_view_win.cc	View	6 chunks	+1 line, -18 lines	3 comments	Download
M	content/content_common.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	views/widget/native_widget_win.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jam

http://codereview.chromium.org/7764010/diff/1/content/browser/renderer_host/render_widget_host_view_gtk.cc File content/browser/renderer_host/render_widget_host_view_gtk.cc (left): http://codereview.chromium.org/7764010/diff/1/content/browser/renderer_host/render_widget_host_view_gtk.cc#oldcode57 content/browser/renderer_host/render_widget_host_view_gtk.cc:57: const char* kRenderWidgetHostViewKey = "__RENDER_WIDGET_HOST_VIEW__"; this code, and below, ...

9 years, 4 months ago (2011-08-26 22:23:36 UTC) #1

http://codereview.chromium.org/7764010/diff/1/content/browser/renderer_host/r...
File content/browser/renderer_host/render_widget_host_view_gtk.cc (left):

http://codereview.chromium.org/7764010/diff/1/content/browser/renderer_host/r...
content/browser/renderer_host/render_widget_host_view_gtk.cc:57: const char*
kRenderWidgetHostViewKey = "__RENDER_WIDGET_HOST_VIEW__";
this code, and below, were added in r38685 for an experimental extension API
used by CEEE. that code was later removed, but not all of it. r98007 removed
some of it in this file, but not this.

http://codereview.chromium.org/7764010/diff/1/content/browser/renderer_host/r...
File content/browser/renderer_host/render_widget_host_view_win.cc (left):

http://codereview.chromium.org/7764010/diff/1/content/browser/renderer_host/r...
content/browser/renderer_host/render_widget_host_view_win.cc:91: const char*
const kRenderWidgetHostViewKey = "__RENDER_WIDGET_HOST_VIEW__";
this is also code from r38685 that's not being used anymore (also line 811)

http://codereview.chromium.org/7764010/diff/1/content/browser/renderer_host/r...
content/browser/renderer_host/render_widget_host_view_win.cc:522: views::Widget*
widget = views::Widget::GetTopLevelWidgetForNativeView(m_hWnd);
I couldn't find any place that called this code, and testing verified that it's
not reachable.

http://codereview.chromium.org/7764010/diff/1/content/browser/renderer_host/r...
content/browser/renderer_host/render_widget_host_view_win.cc:1018:
views::FocusManager::GetWidgetFocusManager()->OnWidgetFocusEvent(window,
this code, and below, were added in r49884 so that extensions can know when the
browser window lost focus to another application.

this particular call isn't actually the ones that does this, it's the one below
in 1027.

that call is redundant when switching between Chrome and another application by
clicking on the other application (the FocusManager listeners get called twice),
since NativeWidgetWin::OnSetFocus gets called in that case. The one case that
wasn't handled, where this code was needed, was when pressing the minimize
button. I've done that in NativeWidgetWin::Minimize().

LGTM

Expand Messages | Collapse Messages