Enable Fixed Layout Mode on TOUCH_UI.

Enable Fixed Layout Mode on TOUCH_UI.

BUG=none
TEST=manually


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98716

[Fady Samuel, 2011-08-26 20:20:13]

This is a first step towards enabling full support of fixed layout mode and
scaling on TOUCH_UI. John, as an OWNER, could you please review? Thanks,

Fady

[jam, 2011-08-26 20:55:59]

http://codereview.chromium.org/7764006/diff/1/content/renderer/render_view.cc
File content/renderer/render_view.cc (right):

http://codereview.chromium.org/7764006/diff/1/content/renderer/render_view.cc...
content/renderer/render_view.cc:265: static const int kDefaultLayoutWidth = 980;
nit: comment?

http://codereview.chromium.org/7764006/diff/1/content/renderer/render_view.cc...
content/renderer/render_view.cc:1237: if
(!frame_url.SchemeIs(chrome::kChromeUIScheme) &&
we really shouldn't be referring to chrome webui schemes and extensions in
content, since those belong in chrome. i realize there are some cases where we
still do, but we want to remove these, so we shouldn't be adding any more. can
you do this in chrome\renderer?

http://codereview.chromium.org/7764006/diff/1/content/renderer/render_view.cc...
content/renderer/render_view.cc:1239: webview()->enableFixedLayoutMode(true);
nit: spacing is off

http://codereview.chromium.org/7764006/diff/1/content/renderer/render_view.h
File content/renderer/render_view.h (right):

http://codereview.chromium.org/7764006/diff/1/content/renderer/render_view.h#...
content/renderer/render_view.h:373: // This is an implementation of a method in
WebViewClient.
nit: this comment is redundant (line 359)

[Fady Samuel, 2011-08-29 18:27:36]

Updated. Could you please take another look, John? Thanks.

Fady

http://codereview.chromium.org/7764006/diff/1/content/renderer/render_view.cc
File content/renderer/render_view.cc (right):

http://codereview.chromium.org/7764006/diff/1/content/renderer/render_view.cc...
content/renderer/render_view.cc:265: static const int kDefaultLayoutWidth = 980;
On 2011/08/26 20:55:59, John Abd-El-Malek wrote:
> nit: comment?

Done.

http://codereview.chromium.org/7764006/diff/1/content/renderer/render_view.cc...
content/renderer/render_view.cc:1237: if
(!frame_url.SchemeIs(chrome::kChromeUIScheme) &&
On 2011/08/26 20:55:59, John Abd-El-Malek wrote:
> we really shouldn't be referring to chrome webui schemes and extensions in
> content, since those belong in chrome. i realize there are some cases where we
> still do, but we want to remove these, so we shouldn't be adding any more. can
> you do this in chrome\renderer?

Done.

http://codereview.chromium.org/7764006/diff/1/content/renderer/render_view.cc...
content/renderer/render_view.cc:1239: webview()->enableFixedLayoutMode(true);
On 2011/08/26 20:55:59, John Abd-El-Malek wrote:
> nit: spacing is off

Done.

http://codereview.chromium.org/7764006/diff/1/content/renderer/render_view.h
File content/renderer/render_view.h (right):

http://codereview.chromium.org/7764006/diff/1/content/renderer/render_view.h#...
content/renderer/render_view.h:373: // This is an implementation of a method in
WebViewClient.
On 2011/08/26 20:55:59, John Abd-El-Malek wrote:
> nit: this comment is redundant (line 359)

Done.

[jam, 2011-08-29 19:14:46]

lgtm with change

http://codereview.chromium.org/7764006/diff/7001/content/renderer/render_view.cc
File content/renderer/render_view.cc (right):

http://codereview.chromium.org/7764006/diff/7001/content/renderer/render_view...
content/renderer/render_view.cc:271: static const char* kHTTPScheme = "http";
this is already defined in content\common\url_constants.h, chrome::kHttpScheme
and chrome:kHttpsScheme

[commit-bot: I haz the power, 2011-08-29 22:25:21]

Change committed as 98716

[Fady Samuel, 2011-09-01 17:24:46]

Hi John, 

Hopefully I've gotten the command line flag placed in the right place this time.
Could you please take a look? Thanks,

Fady

[jam, 2011-09-01 18:17:40]

lgtm

[commit-bot: I haz the power, 2011-09-01 19:39:45]

Try job failure for 7764006-16002 (retry) on mac for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac&number...