Issue 7764003: Fix a crash caused by unknown saved language.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7764003: Fix a crash caused by unknown saved language. (Closed)

Created:
9 years, 4 months ago by MAD

Modified:
9 years, 3 months ago

Reviewers:
commit-bot: I haz the power, Jay Civelli

CC:
chromium-reviews, dfilimon, feldstein

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix a crash caused by unknown saved language. The language index in the dump referred by the crbug is left to -1, meaning that the language passed to TranslateInfoBarDelegate's constructor... The call stack showed that the call came from an auto translate preference, so my only guess would be that a preference was saved for a language that is not available anymore, so I added code to protect against that. BUG=93291 TEST=TranslateManagerTest.UnsupportedSavedLanguage Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98661

Patch Set 1 #

Patch Set 2 : '' #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -2 lines)			Patch
	M	chrome/browser/translate/translate_infobar_delegate.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download
	M	chrome/browser/translate/translate_manager.cc	View	1	1 chunk	+7 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

MAD

Not completely sure if this is the source of the crash, but it's highly probable... ...

9 years, 4 months ago (2011-08-26 19:52:20 UTC) #1

Change committed as 98661

Expand Messages | Collapse Messages