Disable frame pointer optimization on base::debug::StackTrace() so it works properly in release b...

content/plugin/npobject_stub.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/plugin/npobject_stub.h"
 
 #include "content/common/content_client.h"
 #include "content/common/plugin_messages.h"
 #include "content/plugin/npobject_util.h"
 #include "content/plugin/plugin_channel_base.h"
 #include "content/plugin/plugin_thread.h"
 #include "third_party/npapi/bindings/npapi.h"
 #include "third_party/npapi/bindings/npruntime.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebBindings.h"
 #include "webkit/plugins/npapi/plugin_constants_win.h"
 
 using WebKit::WebBindings;
 
+// TODO(eroman): Remove this when done investigating 94179.
+//
+// The following disables optimizations for all the functions in this file.
+//
+// At a minimum we want to disable frame pointer optimization ("y"), so that
+// base::debug::StackTrace() works better. We also prevent inlining of these
+// functions so that StackTrace() is more complete. (The StackTrace() will
+// probably not be able to go deeper than these functions since the callers
+// will probably have FPO).
+//
+// Note that disabling optimizations causes warning 4748 which I have had to
+// disable throughout this file. That warning was:
+//
+//     /GS can not protect parameters and local variables from local buffer
+//     overrun because optimizations are disabled in function
+#if defined(COMPILER_MSVC)
+#pragma optimize("", off)
+MSVC_PUSH_DISABLE_WARNING(4748)
+#endif
+
 NPObjectStub::NPObjectStub(
     NPObject* npobject,
     PluginChannelBase* channel,
     int route_id,
     gfx::NativeViewId containing_window,
     const GURL& page_url)
     : npobject_(npobject),
       channel_(channel),
       route_id_(route_id),
       containing_window_(containing_window),
@@ skipping 349 matching lines @@
 
   bool return_value = WebBindings::evaluateHelper(0, popups_allowed, npobject_,
                                                   &script_string, &result_var);
 
   NPVariant_Param result_param;
   CreateNPVariantParam(
       result_var, channel_, &result_param, true, containing_window_, page_url_);
   NPObjectMsg_Evaluate::WriteReplyParams(reply_msg, result_param, return_value);
   channel_->Send(reply_msg);
 }
+
+// Restore compiler optimizations and warnings.
+#if defined(COMPILER_MSVC)
+MSVC_POP_WARNING()
+#pragma optimize("", on)
+#endif