Issue 7763005: Linux: fix build with system libevent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7763005: Linux: fix build with system libevent. (Closed)

Created:
9 years, 4 months ago by Paweł Hajdan Jr.

Modified:
9 years, 4 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Linux: fix build with system libevent. The libevent gyp target is used by both #host and #target gyp targets, which are present even when not cross-compiling. Mark the system libevent as providing both. This is upstreaming a Gentoo Linux patch. BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98496

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	third_party/libevent/libevent.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

9 years, 4 months ago (2011-08-26 21:14:35 UTC) #2

LGTM with the review description showing why this is needed (either what I
wrote, or your own description of why)

Expand Messages | Collapse Messages