Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 7762013: Added GPU process "echo" IPC message. (Closed)

Created:
9 years, 3 months ago by apatrick_chromium
Modified:
9 years, 3 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, jam, darin-cc_chromium.org
Visibility:
Public.

Description

Added GPU process "echo" IPC message. The echo message is essentially an async fence with event based notification. The client gets a notification when the GPU process has completed all the work up to the last flush. I used it to replace the SwapBuffers / OnSwapBuffers synchronization and got rid of some of the callbacks in the lower layers of the stack. The SwapBuffers callbacks in the GPU process are only needed on mac now and I will replace them with something more generic soon. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98747

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -102 lines) Patch
M content/common/gpu/gpu_channel.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M content/common/gpu/gpu_channel.cc View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M content/common/gpu/gpu_command_buffer_stub.h View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M content/common/gpu/gpu_command_buffer_stub.cc View 1 2 4 chunks +9 lines, -11 lines 0 comments Download
M content/common/gpu/gpu_messages.h View 1 2 3 chunks +7 lines, -3 lines 0 comments Download
M content/renderer/gpu/command_buffer_proxy.h View 1 2 5 chunks +9 lines, -5 lines 0 comments Download
M content/renderer/gpu/command_buffer_proxy.cc View 1 2 5 chunks +23 lines, -8 lines 0 comments Download
M content/renderer/gpu/renderer_gl_context.h View 1 2 4 chunks +5 lines, -6 lines 0 comments Download
M content/renderer/gpu/renderer_gl_context.cc View 1 2 4 chunks +5 lines, -12 lines 0 comments Download
M content/renderer/gpu/webgraphicscontext3d_command_buffer_impl.h View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/gpu/webgraphicscontext3d_command_buffer_impl.cc View 1 2 3 chunks +4 lines, -6 lines 0 comments Download
M content/renderer/pepper_platform_context_3d_impl.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M content/renderer/pepper_platform_context_3d_impl.cc View 1 2 2 chunks +4 lines, -5 lines 0 comments Download
M content/renderer/render_widget_fullscreen_pepper.h View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M content/renderer/render_widget_fullscreen_pepper.cc View 1 2 3 chunks +4 lines, -5 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 2 6 chunks +15 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gpu_scheduler.h View 1 2 3 chunks +8 lines, -6 lines 0 comments Download
M gpu/command_buffer/service/gpu_scheduler.cc View 1 2 1 chunk +0 lines, -8 lines 0 comments Download
M gpu/command_buffer/service/gpu_scheduler_linux.cc View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M gpu/command_buffer/service/gpu_scheduler_mac.cc View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gpu_scheduler_win.cc View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M webkit/plugins/ppapi/plugin_delegate.h View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M webkit/plugins/ppapi/ppb_graphics_3d_impl.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webkit/plugins/ppapi/ppb_graphics_3d_impl.cc View 1 2 3 chunks +5 lines, -3 lines 0 comments Download
M webkit/plugins/ppapi/ppb_surface_3d_impl.h View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/ppb_surface_3d_impl.cc View 1 2 4 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
apatrick_chromium
I'm not finished testing this but it's never too early to call me a lunatic.
9 years, 3 months ago (2011-08-27 01:04:07 UTC) #1
apatrick_chromium
PTAL. Mac seems to work with patch set #2.
9 years, 3 months ago (2011-08-29 21:05:39 UTC) #2
Ken Russell (switch to Gerrit)
This LGTM. I don't have any substantial comments. The simplification looks good and the memory ...
9 years, 3 months ago (2011-08-29 21:50:41 UTC) #3
piman
9 years, 3 months ago (2011-08-29 22:06:31 UTC) #4
LGTM too.

Powered by Google App Engine
This is Rietveld 408576698