Change fetch prebuilt pyauto script to download chromedriver.

pyautolib/fetch_prebuilt_pyauto.py

Index: pyautolib/fetch_prebuilt_pyauto.py
===================================================================
--- pyautolib/fetch_prebuilt_pyauto.py	(revision 98432)
+++ pyautolib/fetch_prebuilt_pyauto.py	(working copy)
@@ -20,11 +20,13 @@
 """
 
 import glob
+import httplib
 import optparse
 import os
 import shutil
 import sys
 import urllib
+import urlparse
 
 import pyauto_utils
 
@@ -54,22 +56,46 @@
     self._outdir = self._options.outdir
     self._url = self._args[0]
 
-    # Setup urls to download
-    self._chrome_zip_name = 'chrome-%s' % { 'linux64': 'linux64bit',
-                                            'linux32': 'linux32bit',
-                                            'mac': 'mac',
-                                            'win': 'win32'
-                                          }[self._options.platform]
+    # Determine name of zip.
+    if not self._options.platform.startswith('linux'):
+      self._chrome_zip_name = 'chrome-%s' % { 'mac': 'mac',
+                                              'win': 'win32'
+                                            }[self._options.platform]
+    else:
+      linux_32_names = ['linux', 'lucid32bit']
+      linux_64_names = ['linux64', 'lucid64bit']
+      linux_names = { 'linux': linux_32_names + linux_64_names,
+                      'linux32': linux_32_names,
+                      'linux64': linux_64_names
+                    }[self._options.platform]
+      for name in linux_names:
+        zip_name = 'chrome-' + name
+        if self._DoesURLExist('%s/%s.zip' % (self._url, zip_name)):
+          self._chrome_zip_name = zip_name
+          break
+      else:
+        assert False, 'Could not find chrome zip at ' + self._url

[Nirnimesh, 2011/08/26 23:55:27]

raise RuntimeError('Could not ...')

[kkania, 2011/08/30 13:30:54]

Done.  What's the guideline for whether to use assert or raise?  I think last
time I had some exception you told me to use assert instead.

[Nirnimesh, 2011/08/30 16:38:34]

You assert on a conditional. Here it's False, so why pretend to use the
conditional.

I must've asked to use assert in test code instead of raising exception. assert
mixes the conditional and exception in one line; or else you'd require an if
conditional: raise Exception(..), but the if part is redundant in this case

+
+    # Setup urls to download.
     self._chrome_zip_url = '%s/%s.zip' % (self._url, self._chrome_zip_name)
     chrome_test_url = '%s/%s.test' % (self._url, self._chrome_zip_name)
     self._pyautolib_py_url = '%s/pyautolib.py' % chrome_test_url
-    self._pyautolib_so_url = '%s/%s' % (chrome_test_url,
-                                        { 'linux64': '_pyautolib.so',
-                                          'linux32': '_pyautolib.so',
-                                          'mac': '_pyautolib.so',
-                                          'win': '_pyautolib.pyd',
-                                         }[self._options.platform])
+    if self._options.platform == 'win':
+      self._pyautolib_so_name = '_pyautolib.pyd'
+      self._chromedriver_name = 'chromedriver.exe'
+    else:
+      self._pyautolib_so_name = '_pyautolib.so'
+      self._chromedriver_name = 'chromedriver'
+    self._pyautolib_so_url = chrome_test_url + '/' + self._pyautolib_so_name
+    self._chromedriver_url = chrome_test_url + '/' + self._chromedriver_name
 
+  def _DoesURLExist(self, url):
+    """Returns whether a resource exists at the given URL."""

[Nirnimesh, 2011/08/26 23:55:27]

s/Returns/Determines/

[kkania, 2011/08/30 13:30:54]

Done.

+    parsed = urlparse.urlparse(url)
+    conn = httplib.HTTPConnection(parsed.netloc)
+    conn.request('HEAD', parsed.path)
+    return conn.getresponse().status == 200
+
   def Cleanup(self):
     """Remove old binaries, if any."""
     pass
@@ -84,9 +110,11 @@
     print self._chrome_zip_url
     print self._pyautolib_py_url
     print self._pyautolib_so_url
+    print self._chromedriver_url
     chrome_zip = urllib.urlretrieve(self._chrome_zip_url)[0]
     pyautolib_py = urllib.urlretrieve(self._pyautolib_py_url)[0]
     pyautolib_so = urllib.urlretrieve(self._pyautolib_so_url)[0]
+    chromedriver = urllib.urlretrieve(self._chromedriver_url)[0]
     chrome_unzip_dir = os.path.join(self._outdir, self._chrome_zip_name)
     if os.path.exists(chrome_unzip_dir):
       print 'Cleaning', chrome_unzip_dir
@@ -96,12 +124,8 @@
     # Copy over the binaries to outdir
     items_to_copy = {
       pyautolib_py: os.path.join(self._outdir, 'pyautolib.py'),
-      pyautolib_so: os.path.join(self._outdir,
-                                 { 'linux64': '_pyautolib.so',
-                                   'linux32': '_pyautolib.so',
-                                   'mac': '_pyautolib.so',
-                                   'win': '_pyautolib.pyd'
-                                  }[self._options.platform])
+      pyautolib_so: os.path.join(self._outdir, self._pyautolib_so_name),
+      chromedriver: os.path.join(self._outdir, self._chromedriver_name)
     }
     unzip_dir_contents = glob.glob(os.path.join(chrome_unzip_dir, '*'))
     for item in unzip_dir_contents:
@@ -128,9 +152,12 @@
       print 'Creating symlink "%s"' % dest
       os.symlink(framework, dest)
 
+    # Set executable bit on chromedriver binary.
+    if not self._options.platform == 'win':

[Nirnimesh, 2011/08/26 23:55:27]

You should do this only if it's not set already

[kkania, 2011/08/30 13:30:54]

Done. What's the reason why we should check first?

[Nirnimesh, 2011/08/30 16:38:34]

Sorry, I got mixed up with the chat we had about file permissions on
chromedriver archiving. I thought the files were getting copied around, but
they're not -- they're downloaded, so you'll need to set the permissions always.

Feel free to revert it back.

+      os.chmod(items_to_copy[chromedriver], 0700)
+
     print 'Prepared binaries in "%s"' % self._outdir
 
 
 if __name__ == '__main__':
   FetchPrebuilt().Run()
-