Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: views/controls/combobox/combobox.cc

Issue 7761011: views: Fix a couple of trivial TODOS. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « views/controls/combobox/combobox.h ('k') | views/controls/combobox/native_combobox_gtk.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "views/controls/combobox/combobox.h" 5 #include "views/controls/combobox/combobox.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/utf_string_conversions.h" 8 #include "base/utf_string_conversions.h"
9 #include "ui/base/accessibility/accessible_view_state.h" 9 #include "ui/base/accessibility/accessible_view_state.h"
10 #include "ui/base/keycodes/keyboard_codes.h" 10 #include "ui/base/keycodes/keyboard_codes.h"
11 #include "ui/base/models/combobox_model.h" 11 #include "ui/base/models/combobox_model.h"
12 #include "views/controls/combobox/native_combobox_wrapper.h"
13 #include "views/controls/native/native_view_host.h" 12 #include "views/controls/native/native_view_host.h"
14 #include "views/widget/widget.h" 13 #include "views/widget/widget.h"
15 14
16 using ui::ComboboxModel; // TODO(beng): remove
17
18 namespace views { 15 namespace views {
19 16
20 // static 17 // static
21 const char Combobox::kViewClassName[] = "views/Combobox"; 18 const char Combobox::kViewClassName[] = "views/Combobox";
22 19
23 //////////////////////////////////////////////////////////////////////////////// 20 ////////////////////////////////////////////////////////////////////////////////
24 // Combobox, public: 21 // Combobox, public:
25 22
26 Combobox::Combobox(ComboboxModel* model) 23 Combobox::Combobox(ui::ComboboxModel* model)
27 : native_wrapper_(NULL), 24 : native_wrapper_(NULL),
28 model_(model), 25 model_(model),
29 listener_(NULL), 26 listener_(NULL),
30 selected_item_(0) { 27 selected_item_(0) {
31 set_focusable(true); 28 set_focusable(true);
32 } 29 }
33 30
34 Combobox::~Combobox() { 31 Combobox::~Combobox() {
35 } 32 }
36 33
(...skipping 98 matching lines...) Expand 10 before | Expand all | Expand 10 after
135 native_wrapper_ = NativeComboboxWrapper::CreateWrapper(this); 132 native_wrapper_ = NativeComboboxWrapper::CreateWrapper(this);
136 AddChildView(native_wrapper_->GetView()); 133 AddChildView(native_wrapper_->GetView());
137 } 134 }
138 } 135 }
139 136
140 std::string Combobox::GetClassName() const { 137 std::string Combobox::GetClassName() const {
141 return kViewClassName; 138 return kViewClassName;
142 } 139 }
143 140
144 } // namespace views 141 } // namespace views
OLDNEW
« no previous file with comments | « views/controls/combobox/combobox.h ('k') | views/controls/combobox/native_combobox_gtk.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698