Issue 7761008: minor fixes to get virtual keyboard work on views desktop without ibus

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7761008: minor fixes to get virtual keyboard work on views desktop without ibus (Closed)

Created:
9 years, 4 months ago by oshima

Modified:
9 years, 3 months ago

Reviewers:
commit-bot: I haz the power, Peng

CC:
chromium-reviews, dhollowa, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

minor fixes to get virtual keyboard work on views desktop without ibus * Call OnTextInputTypeChanged from Mock class (which is used when ibus is not present) * Don't create InputMethod in desktop window. * Fix comment on RWHVV to be more accurate. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98676

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -6 lines)			Patch
M	chrome/browser/renderer_host/render_widget_host_view_views.h	View	1 chunk	+5 lines, -3 lines	0 comments	Download
M	views/ime/mock_input_method.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	views/widget/native_widget_gtk.cc	View	2 chunks	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Peng

On 2011/08/26 22:59:42, oshima wrote: Sorry I can not understand this CL. Is it for ...

9 years, 3 months ago (2011-08-29 01:06:05 UTC) #2

oshima

On 2011/08/29 01:06:05, Peng wrote: > On 2011/08/26 22:59:42, oshima wrote: > > Sorry I ...

9 years, 3 months ago (2011-08-29 17:33:30 UTC) #3

Peng

On 2011/08/29 17:33:30, oshima wrote: > On 2011/08/29 01:06:05, Peng wrote: > > On 2011/08/26 ...

9 years, 3 months ago (2011-08-29 17:36:49 UTC) #4

No LGTM from valid reviewers yet.

Expand Messages | Collapse Messages