Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(809)

Issue 7761007: Update Breakpad to r828 (Closed)

Created:
9 years, 3 months ago by Mark Mentovai
Modified:
9 years, 3 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Update Breakpad to r828 to pick up: ------------------------------------------------------------------------ r828 | mark@chromium.org | 2011-08-26 18:29:33 -0400 (Fri, 26 Aug 2011) | 8 lines Fix a Breakpad crash during teardown when USE_PROTECTED_ALLOCATIONS is in effect. BUG=none TEST=Apple Crash Reporter logs from processes in which Breakpad handles the crash should point the finger at the actual crash source, not the Breakpad thread's attempt to write to unwritable memory. Review URL: http://breakpad.appspot.com/301001 ------------------------------------------------------------------------ r827 | mark@chromium.org | 2011-08-26 17:37:59 -0400 (Fri, 26 Aug 2011) | 5 lines Add missing (parentehses.) BUG=247, chromium:94107 TEST=Minidump file sizes should be manageable Review URL: http://breakpad.appspot.com/300002 ------------------------------------------------------------------------ This also enables USE_PROTECTED_ALLOCATIONS. This should have been on all along because we're using Breakpad through the Framework/Breakpad.mm interface, which requires it. Note that if we ought not have been using USE_PROTECTED_ALLOCATIONS, the build would fail. BUG=94107 TEST=Breakpad should upload reasonably-sized minidump files. Apple Crash Reporter logs from processes in which Breakpad handles the crash should point the finger at the actual crash source, not the Breakpad thread's attempt to write to unwritable memory. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98505

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M breakpad/breakpad.gyp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Mark Mentovai
9 years, 3 months ago (2011-08-26 22:35:00 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698