Adding a special toolchain that will work with chromeos.

Adding a special toolchain that will work with chromeos.

BUG=http://code.google.com/p/chromium-os/issues/detail?id=19719
TEST=None
R=noelallen@google.com,zelidrag@google.com
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98492

[noelallen_use_chromium, 2011-08-26 21:05:35]

http://codereview.chromium.org/7761004/diff/1/build/download_nacl_toolchains.py
File build/download_nacl_toolchains.py (right):

http://codereview.chromium.org/7761004/diff/1/build/download_nacl_toolchains....
build/download_nacl_toolchains.py:13: # Handle chromeos=1 specially (until its
building its own toolchain).
Wow, that is one ugly hack.  :(

I assume the real problem here is that download_toolchains.Main does not take
argv and instead uses sys.argv?  Maybe we should change that (as well as the
main here).

[bradn, 2011-08-26 21:17:39]

PTAL

[noelallen_use_chromium, 2011-08-26 21:37:29]

LGTM

[Mark Seaborn, 2011-08-26 22:26:09]

http://codereview.chromium.org/7761004/diff/3001/build/download_nacl_toolchai...
File build/download_nacl_toolchains.py (right):

http://codereview.chromium.org/7761004/diff/3001/build/download_nacl_toolchai...
build/download_nacl_toolchains.py:18:
'8337d5ec327d857a49b500723ec9b792f4973abc',
So who is going to update this?  How long do you intend this hack to last for?

http://codereview.chromium.org/7761004/diff/3001/build/download_nacl_toolchai...
build/download_nacl_toolchains.py:20: 'nativeclient-archive2/special_chromeos'),
Who uploaded this, and how was it built?

[bradn, 2011-08-26 22:37:16]

I built in on my desk in the chromeos chroot (zelidrag, noel, and I agreed
to this offline, as it continue to allow people experimenting with nacl in
chromeos to make progress).
This is a stopgap until we have an ebuild for chromeos (which much as Ivan
claimed currently just requires turning off gdb).
Victor has committed to shepherding out IRT impacting changes to the newlib
toolchain to the relevant places (chromeos + distros).
This obviously isn't sufficient for ubuntu, but will unblock chromeos
people.

-BradN

On Fri, Aug 26, 2011 at 3:26 PM, <mseaborn@chromium.org> wrote:

>
> http://codereview.chromium.**org/7761004/diff/3001/build/**
>
download_nacl_toolchains.py<http://codereview.chromium.org/7761004/diff/3001/build/download_nacl_toolchains.py>
>
> File build/download_nacl_**toolchains.py (right):
>
> http://codereview.chromium.**org/7761004/diff/3001/build/**
>
download_nacl_toolchains.py#**newcode18<http://codereview.chromium.org/7761004/diff/3001/build/download_nacl_toolchains.py#newcode18>
> build/download_nacl_**toolchains.py:18:
> '**8337d5ec327d857a49b500723ec9b7**92f4973abc',
> So who is going to update this?  How long do you intend this hack to
> last for?
>
> http://codereview.chromium.**org/7761004/diff/3001/build/**
>
download_nacl_toolchains.py#**newcode20<http://codereview.chromium.org/7761004/diff/3001/build/download_nacl_toolchains.py#newcode20>
> build/download_nacl_**toolchains.py:20:
> 'nativeclient-archive2/**special_chromeos'),
> Who uploaded this, and how was it built?
>
>
>
http://codereview.chromium.**org/7761004/<http://codereview.chromium.org/7761...
>