Issue 7760002: Generate locale dlls as a dependency of Chrome Frame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7760002: Generate locale dlls as a dependency of Chrome Frame. (Closed)

Created:
9 years, 4 months ago by tony

Modified:
9 years, 3 months ago

Reviewers:
oshima, ananta

CC:
chromium-reviews, amit

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Generate locale dlls as a dependency of Chrome Frame. Chrome frame has dialogs in generated_resources.grd that are not included in the pak files. They should continue to use the locale dlls. BUG=94362 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98449

Patch Set 1 #

Patch Set 2 : fix dep #

Patch Set 3 : more deps #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+683 lines, -0 lines)			Patch
M	chrome/chrome.gyp	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome_frame/chrome_frame.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	chrome_frame/locales/locales.gyp	View		1 chunk	+678 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

tony

This builds for me. Which binary should I run to make sure this works properly?

9 years, 4 months ago (2011-08-26 17:26:53 UTC) #1

oshima

9 years, 3 months ago (2011-08-30 18:22:05 UTC) #3

On 2011/08/26 17:39:48, ananta wrote:
> LGTM.

Hi, chromeos valgrind bot is getting a lot of mmap errors 
(http://www.mail-archive.com/valgrind-users@lists.sourceforge.net/msg00055.html)
and I'm guessing that's because this change increased static array. (see
crbug.com/28439 and
http://www.mail-archive.com/valgrind-users@lists.sourceforge.net/msg00055.html)

Will it be possible to exclude these resources from ui_tests?

Expand Messages | Collapse Messages