Issue 7757004: RenderWidgetHostViewWin::ReparentWindow should call RemovePropW if kNativeWindowClassFilterProp i...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7757004: RenderWidgetHostViewWin::ReparentWindow should call RemovePropW if kNativeWindowClassFilterProp i... (Closed)

Created:
9 years, 4 months ago by jschuh

Modified:
9 years, 3 months ago

Reviewers:
jam

CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

RenderWidgetHostViewWin::ReparentWindow should call RemovePropW if kNativeWindowClassFilterProp is set. BUG=94402 TEST=None. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98510

Patch Set 1 #

Patch Set 2 : '' #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	content/browser/renderer_host/render_widget_host_view_win.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jschuh

9 years, 3 months ago (2011-08-26 22:58:22 UTC) #3

On 2011/08/26 20:52:58, John Abd-El-Malek wrote:
> lgtm
> 
> you can also put the property in props_

I'm less familiar than I should be with our window wrapper, and this is created
as a bare window. I can circle back and take a look next week to see fi that
would be better.

Expand Messages | Collapse Messages